bugfix nil pointer no target discovered

Signed-off-by: kpango <[email protected]>
vdaas · Mar 2, 2021 · 476f5f9 · 476f5f9
1 parent 691e2f7
commit 476f5f9
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/internal/net/grpc/client.go b/internal/net/grpc/client.go
@@ -573,7 +573,12 @@ func (g *gRPCClient) Connect(ctx context.Context, addr string, dopts ...DialOpti
 				g.atomicAddrs.Add(addr)
 				return conn, nil
 			}
-			log.Warnf("failed to reconnect unhealthy pool addr= %s\terror= %s", addr, err.Error())
+			log.Warnf("failed to reconnect unhealthy pool addr= %s\terror= %s\t trying to disconnect", addr, func() string {
+				if err != nil {
+					return err.Error()
+				}
+				return "connection response is nil or pool is nil"
+			}())
 			err = g.Disconnect(ctx, addr)
 			if err != nil {
 				log.Warnf("failed to disconnect unhealthy pool addr= %s\terror= %s", addr, err.Error())

diff --git a/internal/net/grpc/pool/pool.go b/internal/net/grpc/pool/pool.go
@@ -121,7 +121,7 @@ func New(ctx context.Context, opts ...Option) (c Conn, err error) {
 }
 
 func (p *pool) Connect(ctx context.Context) (c Conn, err error) {
-	if p.closing.Load().(bool) {
+	if p.closing.Load().(bool) || p == nil{
 		return p, nil
 	}