Skip to content

Commit

Permalink
use biome instead of prettier
Browse files Browse the repository at this point in the history
Signed-off-by: kpango <[email protected]>
  • Loading branch information
kpango committed Jan 24, 2024
1 parent 379f197 commit 264b41e
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 16 deletions.
6 changes: 3 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,7 @@
- Fix E2E actions on PR [#2025](https://github.com/vdaas/vald/pull/2025)
- Change E2E actions to use local charts on PR [#2024](https://github.com/vdaas/vald/pull/2024)
- Update format chatops [#2021](https://github.com/vdaas/vald/pull/2021)
- Format code with prettier and gofumpt [#2015](https://github.com/vdaas/vald/pull/2015)
- Format code with biome and gofumpt [#2015](https://github.com/vdaas/vald/pull/2015)

:chart_with_upwards_trend: Metrics/Tracing

Expand Down Expand Up @@ -715,7 +715,7 @@
- Update makefile for "not implemented" placeholder [#1967](https://github.com/vdaas/vald/pull/1977)
- Non-gRPC style error parse result returns Unknown status, it should be re-parse to find inside status [#1981](https://github.com/vdaas/vald/pull/1981)
- Enable gorules [#1980](https://github.com/vdaas/vald/pull/1980)
- Format code with prettier and gofumpt [#1971](https://github.com/vdaas/vald/pull/1971)
- Format code with biome and gofumpt [#1971](https://github.com/vdaas/vald/pull/1971)

:memo: Document

Expand Down Expand Up @@ -1100,7 +1100,7 @@
- Add actions workflow validation [#1902](https://github.com/vdaas/vald/pull/1902)
- Change docker build permission [#1901](https://github.com/vdaas/vald/pull/1901)
- Update docker login action [#1900](https://github.com/vdaas/vald/pull/1900)
- Format code with prettier and gofumpt [#1886](https://github.com/vdaas/vald/pull/1886)
- Format code with biome and gofumpt [#1886](https://github.com/vdaas/vald/pull/1886)
- Update deepsource configuration [#1881](https://github.com/vdaas/vald/pull/1881)
- Update gotestfmt org [#1880](https://github.com/vdaas/vald/pull/1880)
- Add escape for e2e workflow [#1845](https://github.com/vdaas/vald/pull/1845)
Expand Down
14 changes: 7 additions & 7 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -448,26 +448,26 @@ format/go/test: \

.PHONY: format/yaml
format/yaml: \
prettier/install
prettier --write \
biome/install
npx biome --write \
"$(ROOTDIR)/.github/**/*.yaml" \
"$(ROOTDIR)/.github/**/*.yml" \
"$(ROOTDIR)/cmd/**/*.yaml" \
"$(ROOTDIR)/k8s/**/*.yaml"

.PHONY: format/md
format/md: \
prettier/install
prettier --write \
biome/install
npx biome --write \
"$(ROOTDIR)/charts/**/*.md" \
"$(ROOTDIR)/apis/**/*.md" \
"$(ROOTDIR)/tests/**/*.md" \
"$(ROOTDIR)/*.md"

.PHONY: format/json
format/json: \
prettier/install
prettier --write \
biome/install
npx biome --write \
"$(ROOTDIR)/apis/**/*.json" \
"$(ROOTDIR)/charts/**/*.json" \
"$(ROOTDIR)/hack/**/*.json"
Expand All @@ -490,7 +490,7 @@ deps/install: \
gofumpt/install \
strictgoimports/install \
goimports/install \
prettier/install \
biome/install \
go/deps \
go/example/deps

Expand Down
8 changes: 4 additions & 4 deletions Makefile.d/tools.mk
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,10 @@ golines/install: $(GOBIN)/golines
$(GOBIN)/golines:
$(call go-install, github.com/segmentio/golines)

.PHONY: prettier/install
prettier/install: $(BINDIR)/prettier
$(BINDIR)/prettier:
type prettier || npm install -g prettier
.PHONY: biome/install
biome/install: $(BINDIR)/biome
$(BINDIR)/biome:
type biome || npm install -g --save-exact @biomejs/biome

.PHONY: reviewdog/install
## install reviewdog
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ make init
Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/docs/en/emoji-key)):

<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
<!-- prettier-ignore-start -->
<!-- biome-ignore-start -->
<!-- markdownlint-disable -->
<table>
<tbody>
Expand Down Expand Up @@ -295,7 +295,7 @@ Thanks goes to these wonderful people ([emoji key](https://allcontributors.org/d
</table>

<!-- markdownlint-restore -->
<!-- prettier-ignore-end -->
<!-- biome-ignore-end -->

<!-- ALL-CONTRIBUTORS-LIST:END -->

Expand Down

0 comments on commit 264b41e

Please sign in to comment.