Skip to content

Commit

Permalink
fix typo
Browse files Browse the repository at this point in the history
Signed-off-by: Kosuke Morimoto <[email protected]>
  • Loading branch information
kmrmt committed May 27, 2024
1 parent 706e333 commit 248c4d8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions docs/contributing/reviewer-guideline.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ It is intended for internal developers. A separate guideline for external contri

The purpose of this guideline is to clarify what reviewers should be aware of and to optimize communication, thereby facilitating efficient development of Vald.

## Preperation
## Preparation

This guideline assumes that the content of the Pull Request is appropriate.

Expand Down Expand Up @@ -47,7 +47,7 @@ Unless there are high-priority issues, you are in a meeting, or deeply focused o

Regarding quality, while there is always room for improvement, if the quality is sufficient for release, it is acceptable to approve. If there is potential for improvement, suggest it in the comments, and let the implementer decide whether to address it in the same Pull Request or a separate one.

#### What Reviewers Should Do
### What Reviewers Should Do

- If the title or description is unclear, ask questions before reviewing the code.
- If any part of the code is not understood after a brief review, ask for clarification or additional comments instead of trying to understand it yourself.
Expand All @@ -56,7 +56,7 @@ Regarding quality, while there is always room for improvement, if the quality is
- If interrupted, respond even if the review is incomplete.
- Ignore other reviewers' comments.

#### What Reviewers Should Not Do
### What Reviewers Should Not Do

- Try to decipher something that is not immediately understandable.
- Close the browser or tab or start something else if it is not understood.
Expand Down

0 comments on commit 248c4d8

Please sign in to comment.