FIx deepsource

vdaas · Mar 8, 2024 · 125e0c2 · 125e0c2
1 parent 9cef4fe
commit 125e0c2
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 12 deletions.
diff --git a/internal/config/index_operator.go b/internal/config/index_operator.go
@@ -13,7 +13,7 @@
 // limitations under the License.
 package config
 
-// IndexCreation represents the configurations for index creation.
+// IndexOperator represents the configurations for index k8s operator.
 type IndexOperator struct {
 	// AgentName represent agents meta_name for service discovery
 	AgentName string `json:"agent_name" yaml:"agent_name"`

diff --git a/internal/k8s/client/client.go b/internal/k8s/client/client.go
@@ -177,7 +177,7 @@ func (c *client) Watch(ctx context.Context, obj cli.ObjectList, opts ...ListOpti
 	return c.withWatch.Watch(ctx, obj, opts...)
 }
 
-func (c *client) MatchingLabels(labels map[string]string) cli.MatchingLabels {
+func (*client) MatchingLabels(labels map[string]string) cli.MatchingLabels {
 	return cli.MatchingLabels(labels)
 }
 
@@ -259,12 +259,8 @@ func (s *patcher) ApplyPodAnnotations(ctx context.Context, name, namespace strin
 	}
 
 	patch := &unstructured.Unstructured{Object: obj}
-	if err := s.client.Patch(ctx, patch, cli.Apply, &cli.PatchOptions{
+	return s.client.Patch(ctx, patch, cli.Apply, &cli.PatchOptions{
 		FieldManager: s.fieldManager,
 		Force:        ptr.To(true),
-	}); err != nil {
-		return err
-	}
-
-	return nil
+	})
 }
diff --git a/internal/k8s/pod/pod.go b/internal/k8s/pod/pod.go
@@ -111,7 +111,8 @@ func (r *reconciler) Reconcile(ctx context.Context, _ reconcile.Request) (res re
 		pods       = make(map[string][]Pod, len(ps.Items))
 	)
 
-	for _, pod := range ps.Items {
+	for i := range ps.Items {
+		pod := ps.Items[i]
 		if pod.GetObjectMeta().GetDeletionTimestamp() != nil ||
 			(r.namespace != "" && !strings.EqualFold(pod.GetNamespace(), r.namespace)) ||
 			pod.Status.Phase != corev1.PodRunning {

diff --git a/internal/test/mock/k8s/client.go b/internal/test/mock/k8s/client.go
@@ -30,7 +30,7 @@ type ValdK8sClientMock struct {
 
 var _ client.Client = (*ValdK8sClientMock)(nil)
 
-func (m *ValdK8sClientMock) Get(ctx context.Context, name string, namespace string, obj client.Object, opts ...crclient.GetOption) error {
+func (m *ValdK8sClientMock) Get(ctx context.Context, name, namespace string, obj client.Object, opts ...crclient.GetOption) error {
 	args := m.Called(ctx, name, namespace, obj, opts)
 	return args.Error(0)
 }

diff --git a/pkg/index/operator/service/operator.go b/pkg/index/operator/service/operator.go
@@ -153,9 +153,10 @@ func (o *operator) podOnReconcile(ctx context.Context, podList map[string][]pod.
 }
 
 // TODO: implement job reconcile logic to detect save job completion and to start rotation.
-func (o *operator) jobOnReconcile(ctx context.Context, jobList map[string][]job.Job) {
+func (*operator) jobOnReconcile(_ context.Context, jobList map[string][]job.Job) {
 	for k, v := range jobList {
-		for _, job := range v {
+		for i := range v {
+			job := v[i]
 			log.Debug("key", k, "name:", job.Name, "status:", job.Status)
 		}
 	}