add functional option for bbolt

internal/db/kvs/bbolt/bbolt.go

@@ -17,6 +17,7 @@ import (
 	"fmt"
 	"io/fs"
 	"os"
+	"reflect"
 
 	"github.com/vdaas/vald/internal/errors"
 	"github.com/vdaas/vald/internal/sync/errgroup"
@@ -41,8 +42,15 @@ const defaultBucket = "vald-bbolt-bucket"
 // New returns a new Bbolt instance.
 // If file does not exist, it creates a new file. If bucket is empty, it uses default_bucket.
 // If opts is nil, it uses default options.
-func New(file, bucket string, mode fs.FileMode, opts *bolt.Options) (Bbolt, error) {
-	db, err := bolt.Open(file, mode, opts)
+func New(file, bucket string, mode fs.FileMode, opts ...Option) (Bbolt, error) {
+	bopts := new(bolt.Options)
+	for _, opt := range opts {
+		if err := opt(bopts); err != nil {
+			return nil, errors.ErrOptionFailed(err, reflect.ValueOf(opt))
+		}
+	}
+
+	db, err := bolt.Open(file, mode, bopts)
 	if err != nil {
 		return nil, err
 	}

internal/db/kvs/bbolt/bbolt_test.go

@@ -41,7 +41,7 @@ func TestNew(t *testing.T) {
 				tempdir := t.TempDir()
 				tmpfile := filepath.Join(tempdir, "test.db")
 
-				b, err := bbolt.New(tmpfile, "", mode, nil)
+				b, err := bbolt.New(tmpfile, "", mode)
 				require.NoError(t, err)
 				require.NotNil(t, b)
 			},
@@ -58,7 +58,7 @@ func TestNew(t *testing.T) {
 				err = f.Close()
 				require.NoError(t, err)
 
-				b, err := bbolt.New(f.Name(), "", mode, nil)
+				b, err := bbolt.New(f.Name(), "", mode)
 				require.NoError(t, err)
 				require.NotNil(t, b)
 			},
@@ -69,7 +69,7 @@ func TestNew(t *testing.T) {
 				tempdir := t.TempDir()
 				tmpfile := filepath.Join(tempdir, "test.db")
 
-				b, err := bbolt.New(tmpfile, "my bucket name", mode, nil)
+				b, err := bbolt.New(tmpfile, "my bucket name", mode)
 				require.NoError(t, err)
 				require.NotNil(t, b)
 			},
@@ -96,7 +96,7 @@ func Test_bbolt_GetSetClose(t *testing.T) {
 	setup := func(t *testing.T) (b bbolt.Bbolt, file string) {
 		tempdir := t.TempDir()
 		tmpfile := filepath.Join(tempdir, "test.db")
-		b, err := bbolt.New(tmpfile, "", mode, nil)
+		b, err := bbolt.New(tmpfile, "", mode)
 		require.NoError(t, err)
 
 		return b, tmpfile
@@ -140,7 +140,7 @@ func Test_bbolt_GetSetClose(t *testing.T) {
 				require.NoError(t, err)
 
 				// recover from the file
-				b, err = bbolt.New(file, "", mode, nil)
+				b, err = bbolt.New(file, "", mode)
 				require.NoError(t, err)
 
 				res, ok, err := b.Get(k)
@@ -180,7 +180,7 @@ func Test_bbolt_AsyncSet(t *testing.T) {
 
 	tempdir := t.TempDir()
 	tmpfile := filepath.Join(tempdir, "test.db")
-	b, err := bbolt.New(tmpfile, "", mode, nil)
+	b, err := bbolt.New(tmpfile, "", mode)
 	require.NoError(t, err)
 
 	kv := map[string]string{

internal/db/kvs/bbolt/option.go

@@ -0,0 +1,92 @@
+// Copyright (C) 2019-2023 vdaas.org vald team <[email protected]>
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// You may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//	https://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package bbolt
+
+import (
+	"time"
+
+	bolt "go.etcd.io/bbolt"
+)
+
+type Option func(*bolt.Options) error
+
+func WithTimeout(dur time.Duration) Option {
+	return func(opts *bolt.Options) error {
+		opts.Timeout = dur
+		return nil
+	}
+}
+
+func WithNoGrowSync(noGrowSync bool) Option {
+	return func(opts *bolt.Options) error {
+		opts.NoGrowSync = noGrowSync
+		return nil
+	}
+}
+
+func WithNoFreeListSync(noFreeListSync bool) Option {
+	return func(opts *bolt.Options) error {
+		opts.NoFreelistSync = noFreeListSync
+		return nil
+	}
+}
+
+func WithPreLoadFreelist(preloadFreelist bool) Option {
+	return func(opts *bolt.Options) error {
+		opts.NoFreelistSync = preloadFreelist
+		return nil
+	}
+}
+
+func WithReadOnly(readOnly bool) Option {
+	return func(opts *bolt.Options) error {
+		opts.ReadOnly = readOnly
+		return nil
+	}
+}
+
+func WithMmapFlags(flags int) Option {
+	return func(opts *bolt.Options) error {
+		opts.MmapFlags = flags
+		return nil
+	}
+}
+
+func WithInitialMmapSize(initialMmapSize int) Option {
+	return func(opts *bolt.Options) error {
+		opts.InitialMmapSize = initialMmapSize
+		return nil
+	}
+}
+
+func WithPageSize(pageSize int) Option {
+	return func(opts *bolt.Options) error {
+		opts.PageSize = pageSize
+		return nil
+	}
+}
+
+func WithNoSync(noSync bool) Option {
+	return func(opts *bolt.Options) error {
+		opts.NoSync = noSync
+		return nil
+	}
+}
+
+func WithMlock(mlock bool) Option {
+	return func(opts *bolt.Options) error {
+		opts.Mlock = mlock
+		return nil
+	}
+}