Fix dependencies #43
Merged
Fix dependencies #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vankichi <[email protected]>
Signed-off-by: vankichi <[email protected]>
kpango
reviewed
Jun 13, 2023
Makefile
Outdated
| @@ -61,13 +61,16 @@ GOOGLEAPI_PROTOS = \ | |||
| GOOGLEAPI_PROTOS := $(GOOGLEAPI_PROTOS:%=$(GOPATH)/src/github.com/googleapis/googleapis/%) | |||
| NODE_GOOGLEAPIS = $(GOOGLEAPI_PROTOS:$(GOPATH)/src/github.com/googleapis/googleapis/%.proto=$(NODE_ROOT)/%_grpc_pb.js) | |||
|
|
|||
| NODE_VTPROT = $(NODE_ROOT)/planetscale/vtprotobuf/vtproto/ext_grpc_pb.js | |||
There was a problem hiding this comment.
How about naming like below?
Suggested change
| NODE_VTPROT = $(NODE_ROOT)/planetscale/vtprotobuf/vtproto/ext_grpc_pb.js | |
| NODE_VTEXTJS = $(NODE_ROOT)/planetscale/vtprotobuf/vtproto/ext_grpc_pb.js |
There was a problem hiding this comment.
I have fixed it. e103aa3
Signed-off-by: vankichi <[email protected]>
kpango
approved these changes
Jun 13, 2023
hlts2
approved these changes
Jun 13, 2023
vankichi
added a commit
that referenced
this pull request
Jun 13, 2023
* 🐛 Fix Signed-off-by: vankichi <[email protected]> * Revert "Fix dependencies (#43)" This reverts commit 5f10f28. * 🐛 Fix Signed-off-by: vankichi <[email protected]> * Revert "Revert "Fix dependencies (#43)"" This reverts commit bc7dd28. * Revert ":bug: Fix" This reverts commit 925519a. --------- Signed-off-by: vankichi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
I have added
vtprotodependency.WHY
The build failed because there was no
vtprotodependency