Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add actions workflow for verify #147

Merged
merged 3 commits into from
Feb 26, 2024
Merged

Add actions workflow for verify #147

merged 3 commits into from
Feb 26, 2024

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Feb 26, 2024

Description:

As titled

Related Issue:

Versions:

  • Go Version: 1.21.1
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.1
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

Related PR

@hlts2
Copy link
Collaborator Author

hlts2 commented Feb 26, 2024

NOTE: create PR and push to PR

It seems to be able to determine the tag appropriately.
In the case of this PR, the tag is pr-147 for docker build.
https://github.com/vdaas/vald-ci-labs/actions/runs/8044037570/job/21967048384?pr=147

Determined tags: pr-147 nightly
Primary tag: pr-147
...
EXTRA_TAGS is determined: -t vdaas/vald-lb-gateway:pr-147 -t ghcr.io/vdaas/vald-ci-labs/vald-lb-gateway:pr-1477

@hlts2
Copy link
Collaborator Author

hlts2 commented Feb 26, 2024

NOTE: create PR and push to PR

It seems to be able to determine the tag appropriately.
In the case of this PR for main branch, the tag for vald-ci-container image tag detection is nightly.
https://github.com/vdaas/vald-ci-labs/actions/runs/8044111213/job/21967211625?pr=147

Determined tags: pr-147 nightly
Primary tag: pr-147
...
check for vdaas/vald-ci-container
"nightly"
vdaas/vald-ci-container:nightly exists. adding a helm option '--set =nightly'.
HELM_EXTRA_OPTIONS= --set =nightly
IMAGE_TAGS= ="nightly"
...
TAG="nightly"

In the case of a PR to main, a nightly image is used if a PR build (pr-147) does not exist.

@hlts2
Copy link
Collaborator Author

hlts2 commented Feb 26, 2024

The validation results for tag(v.x.x) and release branch(release/vx.x) will be added to this PR.

@hlts2 hlts2 merged commit f314d65 into main Feb 26, 2024
8 checks passed
@hlts2 hlts2 deleted the fix/verify-ci branch February 26, 2024 05:41
@hlts2
Copy link
Collaborator Author

hlts2 commented Feb 26, 2024

NOTE: push to release/vx.x branch

It seems to be able to determine the tag appropriately.
In the case of the push to release/vx.x branch, the tag is the commit hash and release/vx.x for docker build.
https://github.com/vdaas/vald-ci-labs/actions/runs/8045430171/job/21970701887

Determined tags: release/v1.5 839668f5 nightly
Primary tag: release/v1.5
...
EXTRA_TAGS is determined:  -t vdaas/vald-agent-ngt:release/v1.5 -t ghcr.io/vdaas/vald/vald-agent-ngt:release/v1.5 -t vdaas/vald-agent-ngt:839668f5 -t ghcr.io/vdaas/vald/vald-agent-ngt:839668f5

@hlts2
Copy link
Collaborator Author

hlts2 commented Feb 26, 2024

NOTE: create vx.x.x tag

It seems to be able to determine the tag appropriately.
In the case of the creation of vx.x.x, the tag is the vx.x.x, release/vx.x, vx.x commit hash and latest for docker build.
https://github.com/vdaas/vald-ci-labs/actions/runs/8045824697/job/21971840396

Determined tags: v1.5.1 release/v1.5 v1.5 50340b9b latest
Primary tag: v1.5.1
...
EXTRA_TAGS is determined:  -t vdaas/vald-lb-gateway:v1.5.1 -t ghcr.io/vdaas/vald/vald-lb-gateway:v1.5.1 -t vdaas/vald-lb-gateway:release/v1.5 -t ghcr.io/vdaas/vald/vald-lb-gateway:release/v1.5 -t vdaas/vald-lb-gateway:v1.5 -t ghcr.io/vdaas/vald/vald-lb-gateway:v1.5 -t vdaas/vald-lb-gateway:50340b9b -t ghcr.io/vdaas/vald/vald-lb-gateway:50340b9b -t vdaas/vald-lb-gateway:latest -t ghcr.io/vdaas/vald/vald-lb-gateway:latest

@hlts2
Copy link
Collaborator Author

hlts2 commented Feb 27, 2024

NOTE: merge main from PR

It seems to be able to determine the tag appropriately.
In the case of the merge to main, the tag is the commit hash and nightly for docker build.
https://github.com/vdaas/vald-ci-labs/actions/runs/8058694431/job/22011873418

Determined tags: cd73d135 nightly
Primary tag: cd73d135
...
EXTRA_TAGS is determined:  -t vdaas/vald-lb-gateway:cd73d135 -t ghcr.io/vdaas/vald/vald-lb-gateway:cd73d135 -t vdaas/vald-lb-gateway:nightly -t ghcr.io/vdaas/vald/vald-lb-gateway:nightly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant