Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font selection is broken #442

Closed
2xAA opened this issue Sep 14, 2020 · 1 comment · Fixed by #445
Closed

Font selection is broken #442

2xAA opened this issue Sep 14, 2020 · 1 comment · Fixed by #445
Labels
bug Something isn't working released

Comments

@2xAA
Copy link
Member

2xAA commented Sep 14, 2020

Operating system and application version

  • OS: macOS
  • Version 3.0.16

Describe the bug
The font selector in the Text module is broken.

To Reproduce
Steps to reproduce the behavior:

  1. Use the Text module
  2. Click on the font input
  3. See error

Expected behavior
The font-list should load and be usable.

Screenshots
N/A

Additional context
This seems to only be a production build issue.
@2xAA 2xAA added the bug Something isn't working label Sep 14, 2020
2xAA added a commit that referenced this issue Sep 15, 2020
@2xAA
fix(font-selection): adds font-list to externals list
d5fa349 
This tells the build process to use font-list as a node.js module rather than attempt to bundle it
in the renderer bundle

fixes #442
@2xAA 2xAA mentioned this issue Sep 15, 2020
Merged
@2xAA 2xAA closed this as completed in #445 Oct 9, 2020
2xAA added a commit that referenced this issue Oct 9, 2020
@2xAA
fix(font-selection): adds font-list to externals list (#445)
21783ea 
This tells the build process to use font-list as a node.js module rather than attempt to bundle it
in the renderer bundle

fixes #442
2xAA pushed a commit that referenced this issue Oct 9, 2020
@semantic-release-bot
chore(release): 3.2.0
e08fb35 
# [3.2.0](3.1.0...3.2.0) (2020-10-09)

### Bug Fixes

* **font-selection:** adds font-list to externals list ([#445](#445)) ([21783ea](21783ea)), closes [#442](#442)
* fixes logic flow for quit confirmation ([#443](#443)) ([b68e358](b68e358)), closes [#440](#440)

### Features

* **color-picker:** adds custom color picker ([#448](#448)) ([b0cc2ff](b0cc2ff)), closes [#372](#372) [#373](#373)
* **groups:** adds inputlink methods to group controls ([#441](#441)) ([c467b87](c467b87))
@2xAA
Copy link
Member Author

2xAA commented Oct 9, 2020

🎉 This issue has been resolved in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@2xAA 2xAA added the released label Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(font-selection): adds font-list to externals list vcync/modV
1 participant
@2xAA