Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryList: Better object handling #415

Merged
merged 7 commits into from
Sep 18, 2022
Merged

QueryList: Better object handling #415

merged 7 commits into from
Sep 18, 2022

Conversation

tony
Copy link
Member

@tony tony commented Sep 17, 2022

This came up in tmux-python/libtmux#426 when querying lists of dataclass objects

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Merging #415 (432f1e2) into master (1efe871) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

❗ Current head 432f1e2 differs from pull request most recent head d98c54f. Consider uploading reports for the commit d98c54f to get more accurate results

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
- Coverage   61.21%   61.19%   -0.02%     
==========================================
  Files          35       35              
  Lines        2756     2760       +4     
  Branches      660      662       +2     
==========================================
+ Hits         1687     1689       +2     
- Misses        641      642       +1     
- Partials      428      429       +1     
Impacted Files Coverage Δ
tests/_internal/test_query_list.py 100.00% <ø> (ø)
src/libvcs/_internal/query_list.py 55.03% <50.00%> (-0.14%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tony tony force-pushed the querylist-obj branch 2 times, most recently from c7e80ff to 432f1e2 Compare September 18, 2022 15:24
@tony tony force-pushed the querylist-obj branch 2 times, most recently from 28944fd to 73dfe1b Compare September 18, 2022 15:33
@tony tony merged commit 6d0d2fd into master Sep 18, 2022
@tony tony deleted the querylist-obj branch September 18, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant