Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use commit-specific hash for port permalinks #236

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

JavierMatosD
Copy link
Collaborator

This uses "master" instead of a commit hash. This will make the update PRs much smaller since the majority of the changes are just updating the commit in the url.

@JavierMatosD JavierMatosD changed the title Remove commit from url; use 'master' instead Use commit-specific hash for port permalinks Nov 18, 2024
@JavierMatosD
Copy link
Collaborator Author

JavierMatosD commented Nov 19, 2024

This change substantially increases the website rebuild time since into runs two separate git operations for every port in the registry - git log and git rev-list.

This is redundant. I'm going to refactor to use one command and extract both pieces of information. Still slow, but better than current implementation.

Update: now we are capturing both pieces of info, date modified and commit, in one git command. It's still slow but it's similar to what it was before.

@JavierMatosD JavierMatosD merged commit 2c996f3 into vcpkg:main Nov 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants