Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable text selection in tab headers #168

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chausner
Copy link

@chausner chausner commented Jun 7, 2024

This disables the ability for the user to select the text of tab headers. Without this, the cursor changes into a text selection cursor when hovering over tabs which is unexpected.

@JavierMatosD
Copy link
Collaborator

Closing PR as it does not appear to implement the stated changes. Upon review, text selection is still enabled on tab headers.

@chausner
Copy link
Author

chausner commented Jul 1, 2024

@JavierMatosD Just tried it again using Developer Tools and the change works for me. I am talking about these tabs:

image

With the change, when hovering over the tabs, the cursor no longer changes into a selection cursor. Also, double clicking on the tab no longer selects the tab header text.

@JavierMatosD JavierMatosD reopened this Jul 3, 2024
@JavierMatosD
Copy link
Collaborator

JavierMatosD commented Jul 3, 2024

@JavierMatosD Just tried it again using Developer Tools and the change works for me. I am talking about these tabs:

image

With the change, when hovering over the tabs, the cursor no longer changes into a selection cursor. Also, double clicking on the tab no longer selects the tab header text.

@chausner, I'm not seeing this change being applied.
image

@JavierMatosD JavierMatosD marked this pull request as draft July 3, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants