This repository has been archived by the owner on Dec 14, 2020. It is now read-only.
Support setting source selector filter #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more work than I initially anticipated. Seems I never implemented marshalling of maps and completely skipped over described types. Filtering based on offset in a quick Event Hubs test works, but some of the chages are hacky. I want to do a little clean up and think on some of the approaches before merging.
* Added unmarshal method to `describedType`.
* Refactored `readComposite` to try decoding as described type when not
a know composite.
* Modified `LinkSelectorFilter()` to use code in descriptor instead of
string.
* Added `describedType` to marshal tests.
* Added `String()` methods for debugging.
Note: Event Hubs was sending back `0x137000000a` as descriptor code when
`LinkSelectorFilter()` was using a string as the descriptor.
I haven't been able to figure out what that code refers to.
|
I tested the code with and it is working great. 👍 |
|
@torosent Thanks for testing it! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinkSelectorFilter()link option.readCompositeto try decoding as described type when nota know composite.
describedTypeto marshal tests.String()methods for debugging.Note: Event Hubs was sending back
0x137000000aas descriptor code whenLinkSelectorFilter()was using a string as the descriptor. I haven't been able to figure out what that code refers to.