Extra support for python 3 and blockcypher API #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support switching between from mainnet and tesnet without changing class/module - Add base coin implementation - Update test to use single class testnet switching - Fixes #2
Implement common classes for coins
Feature/electrumx servers
Update README.md and scripts
Fix setup.py and scripts
TypeError: 'type' object is not subscriptable
Support bytes in is_hex
…_iteration Replace StopIteration with RuntimeError
Change to v2.0.5
Fix legacy input format
Fix methods
Add more servers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to be able to do the procedure in the README in the testnet in Python 3. This required a large rewrite of the bci.py module. Here is a summary of all changes:
1)Fixed various issues with Python 3 without compromising Python 2 support
2)Removed closed down block explorers blockr and hello block
3)Added blockcypher block explorer api for unspent, fetchtx, pushtx, last block height and block info, and made it to the default (due to testnet support)
4) Additional test cases for interaction with both blockchain.info and blockcypher api
5) Additional test case for making a transaction and pushing it to testnet via the blockcypher api
6) Changed procedure in README to use unspent instead of history to get the inputs for the transaction, as this is more logical, and unspents returned from the explorer APIs are already formatted to be used as inputs.