Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signature form correct for non-std SIGHASH values #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Signature form correct for non-std SIGHASH values #123

wants to merge 1 commit into from

Conversation

wizardofozzie
Copy link
Contributor

Fixes edge case where SIGHASH_ALL = 0 instead of 1

@wizardofozzie
Update transaction.py
fc5eb9f 
Fixes edge case where SIGHASH_ALL = 0 instead of 1
@wizardofozzie wizardofozzie changed the title Update transaction.py Signature form correct for non-std SIGHASH values Oct 25, 2015
@wizardofozzie
Copy link
Contributor Author

Newer BIPs leave open the door for non-standard sighash values

Malformed Txs with sighash = 0 (sighash_all) exist, such as this test vector:

["The following is c99c49da4c38af669dea436d3e73780dfdb6c1ecf9958baa52960e8baee30e73"],
["It is of interest because it contains a 0-sequence as well as a signature of SIGHASH type 0 (which is not a real type)"],
[[["406b2b06bcd34d3c8733e6b79f7a394c8a431fbf4ff5ac705c93f4076bb77602", 0, "DUP HASH160 0x14 0xdc44b1164188067c3a32d4780f5996fa14a4f2d9 EQUALVERIFY CHECKSIG"]],
"01000000010276b76b07f4935c70acf54fbf1f438a4c397a9fb7e633873c4dd3bc062b6b40000000008c493046022100d23459d03ed7e9511a47d13292d3430a04627de6235b6e51a40f9cd386f2abe3022100e7d25b080f0bb8d8d5f878bba7d54ad2fda650ea8d158a33ee3cbd11768191fd004104b0e2c879e4daf7b9ab68350228c159766676a14f5815084ba166432aab46198d4cca98fa3e9981d0a90b2effc514b76279476550ba3663fdcaff94c38420e9d5000000000100093d00000000001976a9149a7b0f3b80c6baaeedce0a0842553800f832ba1f88ac00000000", true]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wizardofozzie