Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected rho definition docstring #130

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Corrected rho definition docstring #130

merged 2 commits into from
Jul 19, 2024

Conversation

phershbe
Copy link
Contributor

Closes #129

chrishavlin
chrishavlin reviewed Jul 19, 2024
View reviewed changes
Copy link
Member

@chrishavlin chrishavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left one comment on an extra small fix.

vbr/vbrCore/functions/density/thermal_expansion_coefficient.m Outdated
@@ -14,7 +14,7 @@
% Output
% -------
% Rho : scalar or array
Copy link
Member

@chrishavlin chrishavlin Jul 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change the Rho on this line to al_int?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, it should say al_int now

@chrishavlin chrishavlin merged commit 871194e into vbr-calc:main Jul 19, 2024
2 checks passed
@chrishavlin chrishavlin added this to the v1.2.0 milestone Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishavlin chrishavlin chrishavlin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

typo in thermal_expansion_coefficient.m
2 participants
@phershbe @chrishavlin