Shorten test names #702
Shorten test names #702
Conversation
Signed-off-by: Elazar Gershuni <[email protected]>
WalkthroughThe pull request modifies macro definitions in the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
- src/test/test_verify.cpp (1 hunks)
🔇 Additional comments (7)
src/test/test_verify.cpp (7)
69-71: LGTM: Simplified test case stringThe removal of the "./check ebpf-samples/" prefix from the TEST_SECTION macro definition aligns with the PR objective of shortening test names. This change simplifies the test case string without altering the functionality, potentially improving readability and reducing the risk of hitting path length limits.
74-76: LGTM: Consistent simplification of test case stringThe TEST_PROGRAM macro definition has been updated in line with the changes made to TEST_SECTION. The removal of the "./check ebpf-samples/" prefix maintains consistency across macro definitions and contributes to the overall goal of shortening test names.
79-81: LGTM: Consistent simplification across macrosThe TEST_PROGRAM_REJECT macro has been updated to remove the "./check ebpf-samples/" prefix, maintaining consistency with the changes made to other macros. This change contributes to the overall goal of shortening test names while preserving the macro's functionality.
84-86: LGTM: Consistent simplification of rejection testThe TEST_SECTION_REJECT macro has been updated in line with the other macro changes, removing the "./check ebpf-samples/" prefix. This change maintains consistency across all test macros and contributes to shorter, more manageable test names.
89-94: LGTM: Consistent simplification of strict rejection testThe TEST_SECTION_REJECT_IF_STRICT macro has been updated to remove the "./check ebpf-samples/" prefix, aligning with the changes made to other macros. This modification contributes to the goal of shortening test names while maintaining the macro's functionality and consistency across the test suite.
97-99: LGTM: Simplified failure test case stringThe TEST_SECTION_FAIL macro has been updated to remove the "ebpf-samples/" prefix while retaining the "expect failure" prefix. This change aligns with the goal of shortening test names and maintains consistency with other macro modifications. The preservation of the "expect failure" prefix ensures that failure test cases remain clearly identifiable.
102-104: LGTM: Consistent simplification of rejection failure testThe TEST_SECTION_REJECT_FAIL macro has been updated in line with the other macro changes, removing the "ebpf-samples/" prefix while retaining the "expect failure" prefix. This modification maintains consistency across all test macros, contributes to shorter test names, and preserves the clear identification of failure test cases.
Catch2 shows inconsistent number of tests. It may be only due to my Clion setup, but it shows many "not found" tests. I believe the issue has something to do with the length of the test's name, so this PR shorten it. The issue does not reproduce again, but it might not be compeletly solved either.
Summary by CodeRabbit
These changes enhance the overall clarity of test definitions, contributing to a more streamlined testing process.