PR feedback

Signed-off-by: Alan Jowett <[email protected]>
vbpf · Jan 8, 2025 · 76a6a71 · 76a6a71
1 parent a864629
commit 76a6a71
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/src/asm_files.cpp b/src/asm_files.cpp
@@ -323,8 +323,6 @@ std::map<std::string, size_t> parse_map_section(const libbtf::btf_type_data& btf
     return map_offsets;
 }
 
-static bool is_map_section(const string& name);
-
 vector<raw_program> read_elf(std::istream& input_stream, const std::string& path, const std::string& desired_section,
                              const ebpf_verifier_options_t& options, const ebpf_platform_t* platform) {
     ELFIO::elfio reader;

diff --git a/src/ebpf_vm_isa.hpp b/src/ebpf_vm_isa.hpp
@@ -88,7 +88,7 @@ enum {
     INST_ALU_OP_END = 0xd0,
     INST_ALU_OP_MASK = 0xf0,
 
-    INST_LD_MODE_IMM = 0x00,      // 64-bit immediate value
+    INST_LD_MODE_IMM = 0x0,       // 64-bit immediate value
     INST_LD_MODE_MAP_FD = 0x1,    // Load map fd
     INST_LD_MODE_MAP_VALUE = 0x2, // Load map value
 };

diff --git a/src/test/test_verify.cpp b/src/test/test_verify.cpp
@@ -424,8 +424,6 @@ TEST_SECTION("falco", "probe.o", "raw_tracepoint/signal_deliver")
 TEST_SECTION_REJECT_IF_STRICT("build", "mapoverflow.o", ".text")
 TEST_SECTION_REJECT_IF_STRICT("build", "mapunderflow.o", ".text")
 
-TEST_SECTION("build", "global_variable.o", ".text")
-
 /*
  * These programs contain "call -1" instruction and cannot be verified:
 TEST_SECTION("raw_tracepoint/filler/sys_access_e")
@@ -527,6 +525,7 @@ TEST_SECTION("build", "store_map_value_in_map.o", ".text")
 TEST_SECTION("build", "twomaps.o", ".text");
 TEST_SECTION("build", "twostackvars.o", ".text");
 TEST_SECTION("build", "twotypes.o", ".text");
+TEST_SECTION("build", "global_variable.o", ".text")
 TEST_PROGRAM("build", "prog_array.o", ".text", "func", 5);
 TEST_PROGRAM("build", "prog_array.o", ".text", "func0", 5);
 TEST_PROGRAM("build", "prog_array.o", ".text", "func1", 5);