Skip to content

Commit

Permalink
tests: disable snapshots when testing partial controller deletion
Browse files Browse the repository at this point in the history
When testing partial deletion the test selects a segment to remove from
controller log. Before deleting the segment but after it was selected it
may be accounted in the controller snapshot.

Disabled controller snapshot to prevent the test racing with
snapshot creation.

Fixes: redpanda-data#8217

Signed-off-by: Michal Maslanka <[email protected]>
(cherry picked from commit f978777)
  • Loading branch information
mmaslankaprv authored and vbotbuildovich committed May 16, 2024
1 parent 0945c56 commit d3cb9a6
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions tests/rptest/tests/controller_erase_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@ def test_erase_controller_log(self, partial):
"""

admin = Admin(self.redpanda)
# disable controller snapshot in partial removal test to make sure that
# the deleted segment is not snapshot before restarting the node
if partial:
self.redpanda.set_cluster_config(
{"controller_snapshot_max_age_sec": 3600})

# Do a bunch of metadata operations to put something in the controller log
transfers_leadership_count = 4
Expand Down

0 comments on commit d3cb9a6

Please sign in to comment.