fix: internationalization issue of tabView title

[yuguaa]

Fix the problem that the tabView title is not switched when internationalization is switched due to the pin and unpin of tabView.

Description

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• New Features

  • Enhanced tab management with the ability to pin and unpin tabs while preserving their titles.
  • Improved handling of affixed tabs to ensure correct property settings.

• Bug Fixes

  • Ensured consistent updates to cached tabs after modifications.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 8457cb2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes involve modifications to the tabbar.ts file within the useTabbarStore Pinia store. Key updates include enhanced logic for pinning and unpinning tabs, ensuring that tab titles are preserved during these operations. The methods _pinTab and _unpinTab have been adjusted to store and apply old tab metadata. Additionally, the setAffixTabs method now ensures that affixed tabs have their affixTab property set to true, while the updateCacheTabs method is called more consistently to maintain accurate cached tab states.

Changes

File	Change Summary
packages/stores/src/modules/tabbar.ts	Updated _pinTab and _unpinTab methods for title preservation; modified setAffixTabs to set affixTab property; consistent calls to updateCacheTabs.

Suggested labels

bug

Suggested reviewers

• anncwb
• vince292007

Poem

In the burrow where tabs do play,
We pin and unpin, come what may.
With titles saved, they hop with glee,
Affixed and true, as they should be!
A joyful dance in the digital fray,
Hooray for tabs, hip-hip-hooray! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)

packages/stores/src/modules/tabbar.ts (3)

309-314: LGTM! Consider adding a comment for clarity.

The changes effectively address the internationalization issue by preserving the tab's title when pinning it. This ensures that the title remains consistent throughout the pinning process.

Consider adding a brief comment explaining why we're preserving the old tab's title:

 const oldTab = this.tabs[index];
 tab.meta.affixTab = true;
+// Preserve the original title to maintain internationalization
 tab.meta.title = oldTab?.meta?.title;

---

415-420: LGTM! Consider adding a comment for consistency.

The changes effectively address the internationalization issue by preserving the tab's title when unpinning it, ensuring consistency with the pinTab method.

For consistency with the pinTab method, consider adding a brief comment explaining why we're preserving the old tab's title:

 const oldTab = this.tabs[index];
 tab.meta.affixTab = false;
+// Preserve the original title to maintain internationalization
 tab.meta.title = oldTab?.meta?.title;

---

Line range hint 1-589: Summary: Internationalization issue successfully addressed

The changes in this PR effectively solve the reported issue of tab titles not updating correctly when changing internationalization settings. The implementation is consistent between pinning and unpinning operations, ensuring that tab titles are preserved throughout these actions.

Key points:

1. The pinTab and unpinTab methods now correctly preserve the original tab title.
2. The changes align with the PR objectives of fixing the internationalization issue for tabView titles.
3. The implementation maintains the existing functionality while addressing the specific bug.

Consider adding unit tests to verify the behavior of pinTab and unpinTab methods with different internationalization settings to ensure long-term maintainability of this fix.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between d5a210f and 8457cb2.

📒 Files selected for processing (1)

• packages/stores/src/modules/tabbar.ts (2 hunks)

🧰 Additional context used

🔇 Additional comments (1)

packages/stores/src/modules/tabbar.ts (1)

Line range hint 365-369: Verify changes mentioned in the AI summary.

The AI-generated summary mentioned modifications to the setAffixTabs method, but there are no visible changes in the provided code. Could you please verify if there were intended changes to this method that might have been omitted?

To confirm if there are any changes to the setAffixTabs method that might not be visible in the diff, you can run the following command:

This will show any differences in the setAffixTabs method between the current version and the previous commit.

[anncwb]

ci没有通过