Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct spelling for 'dragable' #4599

Closed
wants to merge 1 commit into from

Conversation

mynetfan
Copy link
Collaborator

@mynetfan mynetfan commented Oct 10, 2024

Description

拼写修正:dragabledraggable

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Documentation Updates

    • Enhanced clarity on environment variable configuration and preferences settings.
    • Updated terminology from "dragable" to "draggable" for consistency.
  • Code Changes

    • Corrected property names in preferences and UI components to "draggable."
    • Improved localization files to reflect the updated terminology.

Overall, these changes enhance the user experience by ensuring consistent terminology and clearer documentation.

@mynetfan mynetfan requested review from anncwb, vince292007 and a team as code owners October 10, 2024 01:08
Copy link

changeset-bot bot commented Oct 10, 2024

⚠️ No Changeset found

Latest commit: db02bb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mynetfan mynetfan closed this Oct 10, 2024
@mynetfan mynetfan deleted the fix/spelling branch October 10, 2024 01:15
Copy link
Contributor

coderabbitai bot commented Oct 10, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request primarily involve correcting the spelling of "dragable" to "draggable" across various documentation and code files. Documentation updates clarify environment variable configuration and preferences settings. Code modifications include updates to the defaultPreferences object, interface declarations, Vue component properties, and localization files to ensure consistent terminology and improve clarity in the configuration and user interface components.

Changes

File Path Change Summary
docs/src/en/guide/essentials/settings.md, docs/src/guide/essentials/settings.md Documentation updated to clarify environment variable configuration and correct "dragable" to "draggable".
packages/@core/preferences/src/config.ts, packages/@core/preferences/src/types.ts Updated defaultPreferences and TabbarPreferences interface to use "draggable" instead of "dragable".
packages/@core/ui-kit/tabs-ui/src/components/tabs-chrome/tabs.vue, packages/@core/ui-kit/tabs-ui/src/components/tabs/tabs.vue, packages/@core/ui-kit/tabs-ui/src/tabs-view.vue, packages/@core/ui-kit/tabs-ui/src/types.ts, packages/@core/ui-kit/tabs-ui/src/use-tabs-drag.ts Vue components and useTabsDrag function updated to replace "dragable" with "draggable".
packages/effects/layouts/src/basic/tabbar/tabbar.vue, packages/effects/layouts/src/widgets/preferences/blocks/layout/tabbar.vue, packages/effects/layouts/src/widgets/preferences/preferences-drawer.vue Updated variable names from "tabbarDragable" to "tabbarDraggable".
packages/locales/src/langs/en-US.json, packages/locales/src/langs/zh-CN.json Localization files updated to change "dragable" to "draggable".

Suggested reviewers

  • vince292007
  • anncwb

🐇 In the code where "dragable" did dwell,
Now "draggable" rings like a sweet bell.
With docs and components all aligned,
Clarity and correctness, perfectly combined!
Hop along, let’s celebrate this change,
A leap towards better, oh how we arrange! 🥕✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant