chore(@vben-core/tabs-ui): cancel drag and drop function on mobile de…

[wangjue666]

resolve #4301

Description

在移动端下，标签无法切换到已固定标签页，问题是出在sortablejs上，考虑到移动端下的标签不需要拖拽，索性移动端直接禁用拖拽的功能

vue-vben-admin/packages/@core/ui-kit/tabs-ui/src/components/tabs-chrome/tabs.vue

Line 70 in 3f2dcb8

:class="[{ 'is-active': tab.key === active, dragable: !tab.affixTab }]"

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

• If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
• Run the tests with pnpm test.
• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

• New Features

  • Enhanced drag-and-drop functionality for tabs, now optimized for non-mobile devices.
  • Improved responsiveness by disabling drag-and-drop on mobile to enhance usability.

• Bug Fixes

  • Adjusted control flow to prevent unnecessary interactions on touch interfaces.

[changeset-bot]

⚠️ No Changeset found

Latest commit: bb11a98

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes made to the use-tabs-drag.ts file enhance its functionality by introducing a mobile device check that disables drag-and-drop features for tabs on mobile platforms. This adjustment aims to improve usability by preventing interactions that are not suitable for touch interfaces.

Changes

File	Change Summary
packages/@core/ui-kit/tabs-ui/src/use-tabs-drag.ts	Added useIsMobile import, initialized isMobile variable, and modified init function to disable drag-and-drop on mobile devices.

Assessment against linked issues

Objective	Addressed	Explanation
Bug: Mobile devices cannot click tab to return to default tab (#[4301])	✅

🐰 "In the garden, tabs do play,
No dragging now on mobile day.
With a touch, they switch with glee,
A simpler path for you and me!
Hooray for ease, let's hop and cheer,
For tabs that work, we hold so dear!" 🥕

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

Early access features: disabled

We are currently testing the following features in early access:

• Anthropic claude-3-5-sonnet for code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues on the discussion post.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3f2dcb8 and bb11a98.

Files selected for processing (1)

• packages/@core/ui-kit/tabs-ui/src/use-tabs-drag.ts (2 hunks)

Additional comments not posted (2)

packages/@core/ui-kit/tabs-ui/src/use-tabs-drag.ts (2)

7-11: LGTM!

The import statement changes are approved. The addition of useIsMobile from the @vben-core/composables package is a good indication that the code is introducing a mobile device check.

---

97-102: Excellent update to disable drag-and-drop on mobile devices!

The changes in the init function introduce a mobile device check using useIsMobile(). If the current device is mobile, the function exits early, bypassing the initialization of the drag-and-drop functionality for tabs.

This is a great enhancement that improves the user experience on mobile devices by disabling the unnecessary drag-and-drop feature, which may not be suitable for touch interfaces.