Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable darkMenu when theme is 'dark' #4036

Merged
merged 1 commit into from
Aug 4, 2024
Merged

chore: disable darkMenu when theme is 'dark' #4036

merged 1 commit into from
Aug 4, 2024

Conversation

likui628
Copy link
Collaborator

@likui628 likui628 commented Aug 4, 2024

Description

主题跟随系统时允许设置深色菜单
image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Aug 4, 2024

⚠️ No Changeset found

Latest commit: cb40419

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Aug 4, 2024

Walkthrough

The recent changes enhance the user interface for theme preferences in a Vue.js application. The SwitchItem component's disabled state logic has been updated, now allowing it to be enabled when the theme is set to 'light' or any value other than 'dark'. This alteration improves user interaction by providing better feedback based on the current theme, making the UI more intuitive and user-friendly.

Changes

File Path Change Summary
packages/effects/layouts/src/widgets/preferences/... Updated SwitchItem disabled condition to enable when modelValue is 'light' or not 'dark', enhancing user interaction.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ThemeSwitch
    participant App

    User->>ThemeSwitch: Toggle Theme
    ThemeSwitch->>App: Update modelValue
    App->>ThemeSwitch: Check conditions
    Note right of ThemeSwitch: If modelValue is 'dark'
    App->>ThemeSwitch: Disable Switch
    Note right of ThemeSwitch: If modelValue is 'light' or other
    App->>ThemeSwitch: Enable Switch
Loading

Poem

In the garden where themes play,
A switch now brightens the day!
From dark to light, the dance is sweet,
A joyful hop, a cheerful beat!
So toggle with glee, my friend so dear,
The theme is yours, let's spread the cheer! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7994d66 and cb40419.

Files selected for processing (1)
  • packages/effects/layouts/src/widgets/preferences/blocks/theme/theme.vue (1 hunks)
Additional comments not posted (1)
packages/effects/layouts/src/widgets/preferences/blocks/theme/theme.vue (1)

75-75: LGTM! Verify the correctness of the condition.

The change modifies the condition to disable the SwitchItem component when the modelValue is 'dark'. This aligns with the PR objective to disable the dark menu feature based on the theme.

However, ensure that this condition correctly reflects the intended behavior across the application.

@likui628 likui628 changed the title chore: dark menu disable condition chore: Updated darkMenu disabled condition to enable when theme is 'dark' Aug 4, 2024
@likui628 likui628 changed the title chore: Updated darkMenu disabled condition to enable when theme is 'dark' chore: Disabled darkMenu when theme is 'dark' Aug 4, 2024
@likui628 likui628 changed the title chore: Disabled darkMenu when theme is 'dark' chore: disable darkMenu when theme is 'dark' Aug 4, 2024
@anncwb anncwb merged commit 773b36a into main Aug 4, 2024
14 of 16 checks passed
@anncwb anncwb deleted the dark-menu branch August 4, 2024 13:54
@github-actions github-actions bot locked and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants