fix: improve defineConfig types (#4454)

vbenjs · Sep 21, 2024 · d34f1fb · d34f1fb
1 parent 60cffb0
commit d34f1fb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/internal/vite-config/src/typing.ts b/internal/vite-config/src/typing.ts
@@ -137,12 +137,12 @@ type ApplicationOptions = ApplicationPluginOptions;
 
 type LibraryOptions = LibraryPluginOptions;
 
-type DefineApplicationOptions = (config?: ConfigEnv) => Promise<{
+type DefineApplicationOptions = (config: ConfigEnv) => Promise<{
   application?: ApplicationOptions;
   vite?: UserConfig;
 }>;
 
-type DefineLibraryOptions = (config?: ConfigEnv) => Promise<{
+type DefineLibraryOptions = (config: ConfigEnv) => Promise<{
   library?: LibraryOptions;
   vite?: UserConfig;
 }>;

diff --git a/packages/@core/ui-kit/form-ui/__tests__/form-api.test.ts b/packages/@core/ui-kit/form-ui/__tests__/form-api.test.ts
@@ -183,7 +183,7 @@ describe('updateSchema', () => {
     instance.updateSchema(newSchema);
 
     expect(consoleErrorSpy).toHaveBeenCalledWith(
-      'All children of the form Schema array that need to be updated must contain the `field` field',
+      'All items in the schema array must have a valid `fieldName` property to be updated',
     );
   });