Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using deprecated method that is removed in jackson 2.16 #202

Closed

Conversation

pjfanning
Copy link

@pjfanning pjfanning commented Oct 8, 2023

Found when testing with Jackson 2.16. Another change in Jackson 2.16 breaks Either deserialization - it also broke the equivalent code in jackson-module-scala.

@pjfanning pjfanning changed the title stop using deprecatec method that is removed in jackson 2.16 stop using deprecated method that is removed in jackson 2.16 Oct 8, 2023
@pjfanning pjfanning force-pushed the jackson2.16-compile-issue branch from 4b1c7e7 to ef33ff5 Compare October 12, 2023 10:29
@pjfanning
Copy link
Author

The jackson-databind 2.16 change that was breaking vavr-jackson tests is reverted. Unfortunately, this change is still required because a deprecated jackson-databind method has been removed in 2.16.

@pivovarit pivovarit force-pushed the jackson2.16-compile-issue branch from ef33ff5 to c928fdb Compare October 13, 2024 10:04
@pivovarit
Copy link
Member

pivovarit commented Oct 13, 2024

The easiest option to provide compatibility for all versions is to just craft the exception manually: #221

Jackson does no magic and those methods could have been static. Thanks for the effort, though - I took the project over recently and I'm doing the work that's long overdue

@pivovarit pivovarit closed this Oct 13, 2024
@pjfanning pjfanning deleted the jackson2.16-compile-issue branch October 13, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants