Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene: verify (delete?) confusing comment / scene.userData.animations usage #94

Closed
vatro opened this issue Jun 13, 2022 · 1 comment · Fixed by #192
Closed

Scene: verify (delete?) confusing comment / scene.userData.animations usage #94

vatro opened this issue Jun 13, 2022 · 1 comment · Fixed by #192
Assignees
Milestone

Comments

@vatro
Copy link
Owner

vatro commented Jun 13, 2022

  • What was the exact intention behind adding scene.userData.animations (even if it's not being used)?
  • Has something similar been implemented instead?

scene.userData.id = id
scene.userData.sti = sti
// TODO / TOFIX // HÄÄÄ??? This is unused / not implemented!!!
//scene.userData.animations = []

scene.userData.id = id
scene.userData.sti = sti
// TODO / TOFIX // HÄÄÄ??? This is unused / not implemented!!!
//scene.userData.animations = []

@vatro vatro added this to the 1.0.0-next.1 milestone Jun 13, 2022
@vatro vatro self-assigned this Jun 13, 2022
@vatro vatro pinned this issue Dec 5, 2022
@vatro
Copy link
Owner Author

vatro commented Dec 5, 2022

I guess my intention was to be able control / check / manipulate all animations inside a scene via the Scene instance, but that's just a guess. I'll delete it since *.userData.animations isn't used / implemented anywhere.

@vatro vatro linked a pull request Dec 5, 2022 that will close this issue
@vatro vatro closed this as completed in #192 Dec 5, 2022
@vatro vatro unpinned this issue Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant