Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: review start_rendering() and stop_rendering() methods #86

Open
vatro opened this issue Jun 13, 2022 · 0 comments
Open

WebGLRenderer: review start_rendering() and stop_rendering() methods #86

vatro opened this issue Jun 13, 2022 · 0 comments
Labels
good first issue Good for newcomers review
Milestone

Comments

@vatro
Copy link
Owner

vatro commented Jun 13, 2022

Should work as expected, but I did't test them enough (use cases). Test functionality and nail down usage.

// TODO this has to be tested / used / optimized (_isn't used in any of the test scenes up to date_)
/** Cancel any scheduled `requestAnimationFrame` and disable further rendering. */
export function stop_rendering(): void {
enabled = false
cancelAnimationFrame(rAF.id)
render_scheduled.status = false
}
// TODO this has to be tested / used / optimized (_isn't used in any of the test scenes up to date_)
/** Cancel any scheduled `requestAnimationFrame` and disable further rendering. */
export function start_rendering(): void {
enabled = true
start_renderer()
}

@vatro vatro added this to the 1.0.0-next.1 milestone Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers review
Projects
None yet
Development

No branches or pull requests

1 participant