Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propeller.ts : check / remove confusing, old, camera.view related comment #77

Closed
vatro opened this issue Jun 13, 2022 · 1 comment
Closed
Assignees
Milestone

Comments

@vatro
Copy link
Owner

vatro commented Jun 13, 2022

if (objType.includes("Camera")) {
// TODO 'view' property
// updates the camera projection matrix. Must be called after any change of parameters.
if (

@vatro vatro added this to the 1.0.0-next.1 milestone Jun 13, 2022
@vatro vatro self-assigned this Jun 13, 2022
@vatro
Copy link
Owner Author

vatro commented Jun 16, 2022

Looks like a trivial task, but tackles the whole prop updating approach which has been changed several times over the last two years resulting in some confusing legacy code and comments. I don't see any way around reviewing the whole props update approach and get rid of messy, outdated, obsolete parts, may have to squeeze in another major refactor session. 🤷‍♂️

Good thing is this might close a whole bunch of related issues.

@vatro vatro closed this as completed in c7b86ce Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant