Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check / polish setting lights target #136

Closed
80 tasks done
vatro opened this issue Aug 14, 2022 · 1 comment
Closed
80 tasks done

Check / polish setting lights target #136

vatro opened this issue Aug 14, 2022 · 1 comment
Assignees
@vatro
Labels
check / fix / polish refactor
Milestone
1.0.0-next.1

Comments

@vatro
Copy link
Owner

vatro commented Aug 14, 2022 •
edited
Loading

Test extensively & refactor, this has to bulletproof for next.1

Noticed (issues) during testing:

Test: (twice) set target to a component reference + set target to false

  • SpotLight

    • Mesh
    • Object3D
    • Group
    • Scene
    • PointLight
    • SpotLight
    • DirectionalLight
    • OrthographicCamera
    • PerspectiveCamera
    • LoadedGLTF
    • Points

  • DirectionalLight

    • Mesh
    • Object3D
    • Group
    • Scene
    • PointLight
    • SpotLight
    • DirectionalLight
    • OrthographicCamera
    • PerspectiveCamera
    • LoadedGLTF
    • Points

Test: (twice) set target to component's three.js instance reference + set target to false

  • SpotLight

    • Mesh
    • Object3D
    • Group
    • Scene
    • PointLight
    • SpotLight
    • DirectionalLight
    • OrthographicCamera
    • PerspectiveCamera
    • LoadedGLTF
    • Points

  • DirectionalLight

    • Mesh
    • Object3D
    • Group
    • Scene
    • PointLight
    • SpotLight
    • DirectionalLight
    • OrthographicCamera
    • PerspectiveCamera
    • LoadedGLTF
    • Points

Test: (twice) set target to a premade / manually added three.js instance + set target to false

  • SpotLight

    • Mesh
    • Object3D
    • Group
    • Scene
    • PointLight
    • SpotLight
    • DirectionalLight
    • OrthographicCamera
    • PerspectiveCamera
      LoadedGLTF (separate test targeting objects inside a complex loaded GLTF)
    • Points

  • DirectionalLight

    • Mesh
    • Object3D
    • Group
    • Scene
    • PointLight
    • SpotLight
    • DirectionalLight
    • OrthographicCamera
    • PerspectiveCamera
      LoadedGLTF (separate test targeting objects inside a complex loaded GLTF)
    • Points

Test: (twice) set target to a nested (grouped) component reference + set target to false

  • SpotLight

    • (<Group>) Mesh
    • (<Object3D>) Mesh
    • (<Mesh>) Mesh

  • DirectionalLight

    • (<Group>) Mesh
    • (<Object3D>) Mesh
    • (<Mesh>) Mesh

Test: (twice) set target to an object inside a complex loaded GLTF + set target to false

  • SpotLight

    • LoadedGLTF component (just loaded): iterate through LoadedGLTF component's container instance's children (three.js instances) and set them as target.
    • LoadedGLTF component (loaded + generated): iterate through generated svelthree components and set them as target.
    • LoadedGLTF component (loaded + generated): iterate through generated svelthree components' three.js instances and set them as target.
    • Load a GLTF via THREE.GLTFLoader only, add it to the scene, iterate through GLTF container's children (three.js instances) and set them as target.

  • DirectionalLight

    • LoadedGLTF component (just loaded): iterate through LoadedGLTF component's container instance's children (three.js instances) and set them as target.
    • LoadedGLTF component (loaded + generated): iterate through generated svelthree components and set them as target.
    • LoadedGLTF component (loaded + generated): iterate through generated svelthree components' three.js instances and set them as target.
    • Load a GLTF via THREE.GLTFLoader only, add it to the scene, iterate through GLTF container's children (three.js instances) and set them as target.
@vatro vatro added this to the 1.0.0-next.1 milestone Aug 14, 2022
@vatro vatro self-assigned this Aug 14, 2022
vatro pushed a commit that referenced this issue Aug 29, 2022
SvelthreeGLTF.ts improve dx and refactor (add new) types (see #136)
543fe00 
- rename interface `ITreeMember` to `ISvelthreeGLTFTreeMapMember`
- `GLTF` is now passed via constructor, e.g. `const foo: SvelthreeGLTF = new SvelthreeGLTF(loaded_gltf_file: GLTF)`
- `apply(...)` now uses a `Canvas` component reference instead of a `Canvas` DOM Element.
- various `strict: true` related changes (due to `strict: true` in the SvelteKit tests project, see also #153 )
@vatro
Copy link
Owner Author

vatro commented Nov 25, 2022

looking good! ✔️
Also checked after related recent fixes:

@vatro vatro closed this as completed Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vatro vatro

Labels
check / fix / polish refactor
Projects
None yet
Milestone
1.0.0-next.1
Development

No branches or pull requests
1 participant
@vatro