Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server): migration of vm with cbt enabled disk #8017

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Sep 26, 2024

Description

port the fix made 83a8f29 to live migration to ensure Xo don't fall in an infinite loop if disabling CBT succeed BUT the error message VDI_CBT_ENABLED occurs ( which indicate CBT is still enabled )

Hopefully it wil help us find the root cause

introduced by 442dd16

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

Review process

This 2-passes review process aims to:

  • develop skills of junior reviewers
  • limit the workload for senior reviewers
  • limit the number of unnecessary changes by the author
  1. The author creates a PR.
  2. Review process:
    1. The author assigns the junior reviewer.
    2. The junior reviewer conducts their review:
      • Resolves their comments if they are addressed.
      • Adds comments if necessary or approves the PR.
    3. The junior reviewer assigns the senior reviewer.
    4. The senior reviewer conducts their review:
      • If there are no unresolved comments on the PR → merge.
      • Otherwise, we continue with 3.
  3. The author responds to comments and/or makes corrections, and we go back to 2.

Notes:

  1. The author can request a review at any time, even if the PR is still a Draft.
  2. In theory, there should not be more than one reviewer at a time.
  3. The author should not make any changes:
    • When a reviewer is assigned.
    • Between the junior and senior reviews.

@fbeauchamp fbeauchamp marked this pull request as ready for review September 26, 2024 16:17
@fbeauchamp fbeauchamp requested review from stephane-m-dev and removed request for b-Nollet September 27, 2024 09:12
@fbeauchamp fbeauchamp merged commit ad8cd37 into master Sep 30, 2024
1 check passed
@fbeauchamp fbeauchamp deleted the fix_cbt_migration branch September 30, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants