Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/VM): properly identify self user to hide unauthorized actions #7854

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Jul 23, 2024

See Zammad#27288

Description

In order to hide some VM actions from the user, we check if the current user belongs to a resource set. But we also need to check if they belong to a group that belongs to a resource set.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

See Zammad#27288

In order to hide some VM actions from the user, we check if the current user
belongs to a resource set. But we also need to check if they belong to a group
that belongs to a resource set.
@pdonias pdonias requested a review from MathieuRA July 23, 2024 12:29
@MathieuRA MathieuRA merged commit 919d215 into master Jul 23, 2024
1 check passed
@MathieuRA MathieuRA deleted the pierre-fix-self-action-bar branch July 23, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants