Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(netbox): force xo-server to use at least [email protected] #7758

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Jun 20, 2024

See Zammad#24458

xo-server-netbox uses response.text which has been added in [email protected]. Therefore, the dependency version in xo-server needs to be ^1.0.3 to ensure that response.text can be used.

Description

Short explanation of this PR (feel free to re-use commit message)

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

See Zammad#24458

`xo-server-netbox` uses `response.text` which has been added in
[email protected]. Therefore, the dependency version in `xo-server` needs
to be `^1.0.3` to ensure that `response.text` can be used.
@pdonias pdonias requested a review from julien-f June 20, 2024 14:22
@julien-f julien-f merged commit c63d2ab into master Jun 20, 2024
1 check passed
@julien-f julien-f deleted the pierre-fix-netbox-unretrieved-error branch June 20, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants