-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(backups/healtchcheck): healthcheck must be run in task for mirror #7467
Conversation
0369d86
to
7d5da91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of duplicating the _healthCheck()
call in children, mutualize beforeBackup()
and afterBackup()
in the AbstractRemote
instead.
7de7115
to
f8ec566
Compare
2de59cc
to
9f793dc
Compare
c3b35bc
to
caa0560
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me, I let you rebase and merge.
…O cache this can happens when the xo-server is slow to update a faster XO xapi.getObject throw a " no object with UUID or opaque " error during healtcheck phase
caa0560
to
98fe6dc
Compare
do not squash
the afterBackup writer function mark the task as done, healtcheck should be inside the run
source : https://help.vates.tech/#ticket/zoom/21282/88085
Description
Short explanation of this PR (feel free to re-use commit message)
Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md