Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backups/healtchcheck): healthcheck must be run in task for mirror #7467

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

fbeauchamp
Copy link
Collaborator

@fbeauchamp fbeauchamp commented Mar 13, 2024

do not squash

the afterBackup writer function mark the task as done, healtcheck should be inside the run

source : https://help.vates.tech/#ticket/zoom/21282/88085

Description

Short explanation of this PR (feel free to re-use commit message)

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of duplicating the _healthCheck() call in children, mutualize beforeBackup() and afterBackup() in the AbstractRemote instead.

@fbeauchamp fbeauchamp force-pushed the fix_mirror_healthceck branch 2 times, most recently from 7de7115 to f8ec566 Compare March 26, 2024 09:33
@fbeauchamp fbeauchamp force-pushed the fix_mirror_healthceck branch 2 times, most recently from 2de59cc to 9f793dc Compare March 27, 2024 09:50
@julien-f julien-f removed their request for review March 27, 2024 09:51
Copy link
Member

@julien-f julien-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, I let you rebase and merge.

…O cache

this can happens when the xo-server is slow to update a faster XO
xapi.getObject throw a  " no object with UUID or opaque " error during healtcheck phase
@fbeauchamp fbeauchamp merged commit 88c643f into master Mar 28, 2024
1 check passed
@fbeauchamp fbeauchamp deleted the fix_mirror_healthceck branch March 28, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants