Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server/snapshot): allow self user that is member of a group to snapshot #7129

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Oct 26, 2023

See Zammad#18478

Description

VM snapshot: when the VM belongs to a Resource Set, we explicitly bypass SR
permission check for users that are members of that Resource Set to allow them
to snapshot their VMs. But we only checked if the user is in the subjects list
of the Resource Set and forgot to also check the groups the user belongs to.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

@pdonias pdonias requested a review from julien-f October 26, 2023 12:56
@julien-f julien-f merged commit 397b5cd into master Oct 26, 2023
1 check passed
@julien-f julien-f deleted the pierre-fix-self-snapshot branch October 26, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants