Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log failed auth #7061

Merged
merged 2 commits into from
Sep 28, 2023
Merged

Log failed auth #7061

merged 2 commits into from
Sep 28, 2023

Conversation

julien-f
Copy link
Member

@julien-f julien-f commented Sep 28, 2023

Review by commits and ignore white spaces, DO NOT SQUASH.

Description

Screenshot from 2023-09-28 15-04-11

Clicking on the </> button show the raw log which provide more info:

{
  "id": "0ln36jhbq",
  "properties": {
    "credentials": {
      "username": "john.smith"
    },
    "userData": {
      "ip": "93.184.216.34"
    },
    "name": "XO user authentication",
    "type": "xo:authentication:authenticateUser"
  },
  "start": 1695905824888,
  "status": "failure",
  "updatedAt": 1695905824897,
  "end": 1695905824897,
  "result": {
    "code": 3,
    "message": "invalid credentials",
    "name": "XoError",
    "stack": "XoError: invalid credentials\n    at invalidCredentials (/usr/local/lib/node_modules/xo-server/node_modules/packages/xo-common/api-errors.js:26:11)\n    at file:///usr/local/lib/node_modules/xo-server/src/xo-mixins/authentication.mjs:169:17\n    at Task.runInside (/usr/local/lib/node_modules/xo-server/node_modules/@vates/task/index.js:158:22)\n    at Task.run (/usr/local/lib/node_modules/xo-server/node_modules/@vates/task/index.js:141:20)\n    at Strategy._verify (file:///usr/local/lib/node_modules/xo-server/src/index.mjs:283:26)"
  }
}

But this view should be improved in the future to make task properties more directly accessible.

Checklist

  • Commit
    • Title follows commit conventions
    • Reference the relevant issue (Fixes #007, See xoa-support#42, See https://...)
    • If bug fix, add Introduced by
  • Changelog
    • If visible by XOA users, add changelog entry
    • Update "Packages to release" in CHANGELOG.unreleased.md
  • PR
    • If UI changes, add screenshots
    • If not finished or not tested, open as Draft

CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
@julien-f julien-f force-pushed the log-failed-auth branch 5 times, most recently from c0e05b9 to 4f419ac Compare September 28, 2023 15:34
@pdonias pdonias merged commit 73755e4 into master Sep 28, 2023
1 check passed
@pdonias pdonias deleted the log-failed-auth branch September 28, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants