Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(xo-web/VM): display creator email and template name #6771

Merged
merged 7 commits into from
Apr 25, 2023

Conversation

MathieuRA
Copy link
Member

@MathieuRA MathieuRA commented Apr 4, 2023

See xoa-support #13064 & #13094

Screenshot

Capture d’écran de 2023-04-25 15-30-49

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@MathieuRA MathieuRA self-assigned this Apr 5, 2023
CHANGELOG.unreleased.md Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-general.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-general.js Outdated Show resolved Hide resolved
packages/xo-web/src/xo-app/vm/tab-general.js Outdated Show resolved Hide resolved
@MathieuRA MathieuRA removed the request for review from pdonias April 19, 2023 07:40
Copy link
Contributor

@Rajaa-BARHTAOUI Rajaa-BARHTAOUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add.

@pdonias pdonias changed the title feat(xo-web/vm): display creator email and template name feat(xo-web/VM): display creator email and template name Apr 25, 2023
@pdonias pdonias merged commit 0583a97 into master Apr 25, 2023
@pdonias pdonias deleted the mathieu/vm-display-creator branch April 25, 2023 14:19
@pdonias pdonias mentioned this pull request Sep 14, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants