Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-web/backup/restore): don't use UNSAFE_componentWillReceiveProps #6364

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Aug 10, 2022

Introduced by 7d6e832

UNSAFE_componentWillReceiveProps method was only introduced in React 16 but we
are using React 15
.eslintrc: ask eslint to check the React version so that it doesn't suggest to
change it to UNSAFE_componentWillReceiveProps

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

Introduced by 7d6e832

`UNSAFE_componentWillReceiveProps` method was only introduced in React 16 but we
are using React 15
`.eslintrc`: ask eslint to check the React version so that it doesn't suggest to
change it to `UNSAFE_componentWillReceiveProps`
@pdonias pdonias changed the title fix(xo-web/backup/restore): don't use UNSAFE_componentWillReceiveProps fix(xo-web/backup/restore): don't use UNSAFE_componentWillReceiveProps Aug 10, 2022
@pdonias pdonias merged commit 18d03a0 into master Aug 11, 2022
@pdonias pdonias deleted the pierre-fix-backup-list branch August 11, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants