Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(xo-server/xapi-object-to-xo): handle guest metrics reporting empty IP field #6328

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

pdonias
Copy link
Member

@pdonias pdonias commented Jul 25, 2022

See https://xcp-ng.org/forum/topic/4810/netbox-plugin-error-ipaddr-the-address-has-neither-ipv6-nor-ipv4-format/27?_=1658735770330

Check list

Check if done, if not relevant leave unchecked.

  • PR reference the relevant issue (e.g. Fixes #007 or See xoa-support#42)
  • if UI changes, a screenshot has been added to the PR
  • documentation updated
  • CHANGELOG.unreleased.md:
    • enhancement/bug fix entry added
    • list of packages to release updated (${name} v${new version})
  • I have tested added/updated features (and impacted code)

Process

  1. create a PR as soon as possible
  2. mark it as WiP: (Work in Progress) if not ready to be merged
  3. when you want a review, add a reviewer (and only one)
  4. if necessary, update your PR, and re- add a reviewer

From the Four Agreements:

  1. Be impeccable with your word.
  2. Don't take anything personally.
  3. Don't make assumptions.
  4. Always do your best.

@pdonias pdonias requested a review from MathieuRA July 25, 2022 12:19
@MathieuRA MathieuRA requested review from fbeauchamp and Rajaa-BARHTAOUI and removed request for Rajaa-BARHTAOUI July 25, 2022 14:17
@pdonias pdonias requested a review from fbeauchamp July 26, 2022 12:24
@pdonias pdonias merged commit 433851d into master Jul 27, 2022
@pdonias pdonias deleted the pierre-handle-empty-ip branch July 27, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants