Compatability with Netbox 4.1

[ChrisMcNichol]

Is your feature request related to a problem? Please describe.
Netbox v4.1.0 has made a change to the VM Disk Size unit from 1 GB to 1MB. Disk sizes will get changed for example from 100GB to 100MB.

Describe the solution you'd like
Update to the Netbox plugin to account for this change.

Additional context
From testing in a dev environment, this can be overcome by changing the line specifying the const G variable from 1024 ** 3 to (1024 ** 3)/1000.
This allows the plugin to correctly update Netbox with the VM disk size in GB, but obviously does not in itself allow for backwards compatibility with Netbox v.4.0.x

[olivierlambert]

Hi,

Thanks for your report. I agree, we need to make the change. However, I have to admit I'm fed up with Netbox breaking many things after each minor release (I'm not even talking about 4.0). The problem is we cannot guarantee nobody will use <4.1, so we need to make the code even more complex to handle this 😞

[ChrisMcNichol]

@olivierlambert
You are correct, it is annoying when these things break the plugin.
For this change, I can only think we will have to check the Netbox version and change the variable based on that, although that is more of a temporary fix, as we can't afford to keep adding extra version checks for any small thing that needs changing due to changes in Netbox.

[olivierlambert]

Yes, @pdonias will take the appropriate action, but I hope this won't continue at this pace.