Add dynamic slider range and step update #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default range min/max values set to be 0/100 respectively. Those ranges and step is updated on change using angular scope.$watch()'es.
|
+1 Please merge. Works fine. |
Fixes slider change from model bug (slider change to X second time fails): Slide to value X -> Model change to value Y -> Model change to value X.
|
I haven't had this issue with single knob slider. However it might be a problem on some browsers due to unsafe equality to "null" check. Better approach here is to use "angular.isUndefined()". |
|
Sorry for the late response. Your code worked just fine, it was me not initiating the ngFrom and ngTo variables when the controller was loaded. Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful to have such thing when slider ranges is not known on initialization or they are changed during runtime. Most of sliders providers have such feature. Would be great to have it in this wrapper.
I am not sure if it is the right way to do it but angular scope.$watch()'es fits here. On the other hand attrs.$observe() might be more performance friendly way. Also default default range min/max values should be set. Using those 0/100 respectively.