Added ability to create custom animations for the overlay-background and standard jquery events using .on and .trigger methods. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s that either do not set transitions or do not support it. Should be tied together with Modernizer.csstransitions.
|
@vladimirsiljkovic Yes, I'm using that to allow for completely dynamic popups. I try to abstract most of my code, especially when I use libraries. I needed it for my dynamic popups, but if you don't think you need it in the library, that's fine. Just thought I'd contribute the changes I needed in case somebody else had the same problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the ability to set the class of the overlay background in order to create animations on it. In addition, you can use $("my_overlay").on("jquery-popup-overlay.someevent", function(){}). This allows post-creating event binding and removal.