Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh Dynamic Property by name #13526

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

riverwanderer
Copy link
Collaborator

Add Dynamic Property to traits that can be refreshed by name. Intended resolution for #13085.

@riverwanderer riverwanderer added this to the 3.7.14 milestone Aug 11, 2024
@riverwanderer
Copy link
Collaborator Author

The update as-is does not work. Submitting for review / advice.
The Dynamic Property by name processing is based on the code for Rotate.
Predefined Setups not yet enabled. Using single game refresh for initial testing.

Issues / questions:

  1. The Rotate test in GpidChecker.java (line ~359) uses the trait name to match candidates for refresh copying. Is this test sufficient for Dynamic Property?

  2. A test refresh using Dynamic Property by name corrupts Dynamic Property settings in the game file. Perhaps, myGetState() / mySetState() needs to be expanded for the Dynamic Property class to support refresh by name?

  3. Related to (1), these errors are generated in the test refresh (using CCN v5, scenario 001):

- Bad Data in Module: Source: followProperty[{StrengthNumber_Level == 1 ? Strength : 0}]=false Error: Portuguese Light Cavalry [Layer] . Numeric field contains a non-number.
- Bad Data in Module: Source: followProperty[$MarkerLevel$]=false Error: Portuguese Light Cavalry [Layer] . Numeric field contains a non-number.
  1. The (newly added) testing for Dynamic Property in GpidChecker seems not to exclude Set Global Property traits, based on Debug breakpoint tests.

@riverwanderer riverwanderer marked this pull request as draft August 11, 2024 12:54
@uckelman uckelman modified the milestones: 3.7.14, 3.7.15 Aug 18, 2024
@uckelman uckelman modified the milestones: 3.7.15, 3.7.16 Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants