Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor search regex revamp radio buttons #12795

Closed
wants to merge 44 commits into from
Closed

Editor search regex revamp radio buttons #12795

wants to merge 44 commits into from

Conversation

riverwanderer
Copy link
Collaborator

No description provided.

riverwanderer and others added 30 commits October 2, 2023 18:59
@riverwanderer
More efficient Regex search with improved user experience.
b0e0267
@riverwanderer
PMD.
4bdbca6
@riverwanderer
Fix problem with getNumMatches() ?
a2acbda
@riverwanderer
Debugging
b6bc8e6
@riverwanderer
Debugging
40c8f9f
@riverwanderer
Regex Pattern parameter passing now consistent.
a6fbe96
@riverwanderer
Debugging
108ecf2
@riverwanderer
Debugging
2ba819f
@riverwanderer
PMD
2707ccf
@riverwanderer
Revert to v3.7.1 parameter lists (regexPattern is global).
509a71c
@riverwanderer
Debugging.
86eccd9
@riverwanderer
Debugging.
05c8368
@riverwanderer
Debugging.
90e95d4
@riverwanderer
Remove debugging code. Amend doc and message (adds Regex specific hea…
8d6a5b9 
…der message).
@riverwanderer
Merge remote-tracking branch 'origin/editor-search-regex-revamp' into…
5e8f6ec 
… editor-search-regex-revamp

# Conflicts:
#	vassal-app/src/main/java/VASSAL/configure/ConfigureTree.java
@riverwanderer
Restore accidentally deleted word.
10d3872
@riverwanderer
Restore accidentally deleted word. Message debugging & highlighting. …
6bcd19a 
…Search session clarification in doc.
@riverwanderer
chatter.show does not do colour controls. When announcing match count…
d9638b1 
… or not found, show Regex pattern specifically, in case of default.
@riverwanderer
debug default regex search. Remove bold tag for now as it wasn't work…
3462a7a 
…ing (unlike underline elsewhere).
@riverwanderer
replace regex checkbox with 3 options in a dropdown list.
05437bc
@riverwanderer
debug default regex search. Remove bold tag for now as it wasn't work…
da3afa5 
…ing (unlike underline elsewhere).
@riverwanderer
Merge remote-tracking branch 'origin/editor-search-regex-revamp-dropd…
d7c7a78 
…own' into editor-search-regex-revamp-dropdown
@riverwanderer
Debugging.
7a4e44e
@riverwanderer
Debugging.
8ba8a60
@riverwanderer
PMD.
ae336d9
@riverwanderer
Properties
dea07e3
@riverwanderer
Dropdown using JComboBox.
a8a7f51
@riverwanderer
Merge remote-tracking branch 'origin/editor-search-regex-revamp-dropd…
cfcb2fd 
…own' into editor-search-regex-revamp-dropdown

# Conflicts:
#	vassal-app/src/main/resources/VASSAL/i18n/Editor.properties
@riverwanderer
Switch to radio buttons for search type.
9ad3a72
@riverwanderer
Switch to radio buttons for search type.
30431e8
riverwanderer and others added 14 commits October 9, 2023 00:56
@riverwanderer
Merge remote-tracking branch 'origin/editor-search-regex-revamp-radio…
5eaa369 
…buttons' into editor-search-regex-revamp-radiobuttons

# Conflicts:
#	vassal-app/src/main/java/VASSAL/configure/ConfigureTree.java
@riverwanderer
Merge branch 'master' of https://github.com/riverwanderer/vassal into…
98bea7b 
… editor-search-regex-revamp-radiobuttons
@riverwanderer
Group radio buttons on a line.
257a83a
@riverwanderer
PMD
c95632c
@riverwanderer
PMD
9cf5842
@riverwanderer
Merge remote-tracking branch 'origin/editor-search-regex-revamp-radio…
043db41 
…buttons' into editor-search-regex-revamp-radiobuttons

# Conflicts:
#	vassal-app/src/main/java/VASSAL/configure/ConfigureTree.java
@riverwanderer
documentation.
3989d76
@riverwanderer
documentation.
ea2d681
@riverwanderer
documentation image fixes.
f5771e0
@riverwanderer
Highlight found text and track component count.
ad116b5
@riverwanderer
Highlight found text and track component count.
79ad03f
@riverwanderer
Merge remote-tracking branch 'origin/editor-search-regex-revamp-radio…
1b831d4 
…buttons' into editor-search-regex-revamp-radiobuttons

# Conflicts:
#	vassal-app/src/main/java/VASSAL/configure/ConfigureTree.java
@riverwanderer
PMD / shift from searchString to regexPattern for internals.
8161329
@riverwanderer
Reset parameters at module start. Message count fix.
69b74e4
@riverwanderer riverwanderer added the On Hold Waiting for other changes label Oct 11, 2023
@riverwanderer riverwanderer mentioned this pull request Oct 11, 2023
Merged
@Cattlesquat
Copy link
Collaborator

Should this PR be closed if it's being superseded? Closed PRs can still be looked at (by looking at closed PRs), can be re-opened later if needed, and none of their code checkins go away or anything

@riverwanderer riverwanderer deleted the editor-search-regex-revamp-radiobuttons branch November 25, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
On Hold Waiting for other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@riverwanderer @Cattlesquat