Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Player joins as side" message now broadcast to all players #12768

Merged
merged 9 commits into from
Jan 9, 2024
Merged

"Player joins as side" message now broadcast to all players #12768

merged 9 commits into from
Jan 9, 2024

Conversation

riverwanderer
Copy link
Collaborator

No description provided.

@riverwanderer riverwanderer self-assigned this Sep 30, 2023
@riverwanderer riverwanderer added this to the 3.7.2 milestone Sep 30, 2023
@riverwanderer riverwanderer added the bug Something isn't working label Sep 30, 2023
@riverwanderer riverwanderer linked an issue Sep 30, 2023 that may be closed by this pull request
Player joining message is not sent to other players #12749
Closed
@riverwanderer
Copy link
Collaborator Author

riverwanderer commented Sep 30, 2023 •
edited
Loading

Re-tested - as expected message is output to other players but not for the first player who joins a room. This fix is a pre-req for PR #12743.

@riverwanderer riverwanderer added the Ready for Review Ready to be reviewed for Merging label Sep 30, 2023
@BrentEaston BrentEaston added Review-Changes Requested Reviewer has request changes and removed Ready for Review Ready to be reviewed for Merging labels Oct 4, 2023
@uckelman uckelman modified the milestones: 3.7.2, 3.7.3 Oct 8, 2023
@uckelman uckelman modified the milestones: 3.7.3, 3.7.4, 3.7.5 Oct 16, 2023
@uckelman uckelman modified the milestones: 3.7.5, 3.7.6 Oct 30, 2023
riverwanderer and others added 2 commits October 31, 2023 01:11
@riverwanderer
Merge branch 'master' of https://github.com/riverwanderer/vassal into…
4225ec3 
… joined-player-msg-fix
@riverwanderer
Change 3x sendToOthers() calls to sendAndLog(), covering both joining…
11ffd6c 
… and changing sides. Retain previous calls as comments, until this change is proven
@uckelman uckelman modified the milestones: 3.7.6, 3.7.7 Dec 8, 2023
@BrentEaston BrentEaston added Ready to Merge YeeeeeeeeeeeHAW!!! and removed Review-Changes Requested Reviewer has request changes labels Dec 8, 2023
@uckelman uckelman changed the title Player joins as side msg shared to all. "Player joins as side" message now broadcast to all players Jan 9, 2024
@uckelman uckelman merged commit 52b03d5 into vassalengine:master Jan 9, 2024
1 check passed
@riverwanderer riverwanderer deleted the joined-player-msg-fix branch April 15, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrentEaston BrentEaston BrentEaston approved these changes

Assignees

@riverwanderer riverwanderer

Labels
bug Something isn't working Ready to Merge YeeeeeeeeeeeHAW!!!
Projects
None yet
Milestone
3.7.7
Development

Successfully merging this pull request may close these issues.

Player joining message is not sent to other players
3 participants
@riverwanderer @BrentEaston @uckelman