Updated for 3.5.8 release.

vassalengine · Jun 29, 2021 · 622d764 · 622d764
1 parent 58153d7
commit 622d764
Show file tree

Hide file tree

Showing 11 changed files with 83 additions and 189 deletions.
diff --git a/Makefile b/Makefile
@@ -49,9 +49,9 @@ JDOCDIR:=jdoc
 # numeric part of the version only
 VNUM:=3.5.8
 
-MAVEN_VERSION:=$(VNUM)-SNAPSHOT
+#MAVEN_VERSION:=$(VNUM)-SNAPSHOT
 #MAVEN_VERSION:=$(VNUM)-beta3
-#MAVEN_VERSION:=$(VNUM)
+MAVEN_VERSION:=$(VNUM)
 
 JARNAME:=vassal-app-$(MAVEN_VERSION)
 

diff --git a/dist/notes/NOTES-bgg.jinja b/dist/notes/NOTES-bgg.jinja
@@ -14,57 +14,29 @@ The VASSAL Team is happy to announce VASSAL {{version}}.
 [url=https://github.com/vassalengine/vassal/releases/download/{{version}}/VASSAL-{{version}}-windows-32.exe]Windows (32-bit)[/url]
 [url=https://github.com/vassalengine/vassal/releases/download/{{version}}/VASSAL-{{version}}-other.zip]Other[/url]
 
-[size=16][b]Changes since 3.5.6[/b][/size]
+[size=16][b]Changes since 3.5.7[/b][/size]
 
 Bug fixes
 
-* 14540: PgDn stopped scrolling maps downward
-* 14527: NoSuchMethodError when calling ArchiveWriter.save()
-* 14526: IllegalArgumentException when rendering empty labels
-* 14521: NPE in CounterDetailViewer when Stack shapes array is longer than the piece count
+* 14599: Error logs should be read from disk as UTF-8
+* 14596: Removed initial heap setting for Importer, unused since 3.5.4
+* 14579: Mass Piece Loader cannot add 'standard' layer traits
+* 14570: Longer cancel wizard text shifts wizard divider position
+* 14568: Counter Global Key Command expression does not see properties in lower traits
+* 14479: GamePieceImages recognized by unused image removal tool
 
-[size=16][b]Changes since 3.5.5[/b][/size]
+Other improvements
 
-Bug fixes
+* 14600: Switch bug tracker to GitHub
 
-* 14518: Zoomer hotkeys should take effect only if their map is focused
-* 14506: NPE in PieceWindow.launchButtonPressed()
-* 14505: Edit Extension menu item should be disabled when the extension is already being edited
-* 14504: Improved results for users who started with no password and then set one later
-* 14503: Set errorLog encoding explicitly to UTF-8
-* 14502: Tailer misdecodes errorLog
-* 14484: Module editing permanently disabled after editing associated Extension
-* 14469: Java's ProcessBuilder misencodes Unicode outside Latin1 on Windows
-* 14468: MouseoverStackViewer: corrected text centering problem with "extra space between" setting
-* 14461: NPE in TableInfo.getExpressionList()
-* 14460: StackOverflowError when referencing _Level property in layer-following expression
-* 14456: ConcurrentModificationException in GameState.setup() when component setup() adds components
-* 14452: Catch PatternSyntaxException on user-provided regexes
-* 14440: Counter refresh function sometimes changes stacking order of pieces
-* 14422: ArrayIndexOutOfBoundsException in Embellishment.getProperty()
-* 14418: MassPieceLoader: Copy/Paste of Modified Layer trait generates Standard Layer on Paste
-* 14401: Cancelling a predefined-setup load during setup wizard shouldn't show "Loaded..." message
-* 14393: Don't show that sending bug reports failed when they've succeeded
-* 14386: Editor was reporting module saved when the "confirm overwrite" dialog cancelled
-* 14370: NPE in BasicLogger.write() when there is no game state to write
-* 14368: Using String functions on property names containing double quotes in value causes Bad Module Data errors
-* 14351: NPE when Player Roster deleted from module
-* 14337: Show/Hide Palette Hotkey shows but does not hide
-* 14325: TileNotFoundException after second copy of a module in use is removed
-* 14311: Cancelling edit where a Hotkey name was changed does not cancel changes
-* 14308: Bad encoding in errorLog, bug reports
-* 14286: Prevent bad expressions from returning null
-* 14271: Chat & Notes input panel(s) treat Hotkeys differently
-* 14261: StackOverflowError: Infinite loop caused by Text Label wasn't being caught properly
-* 10755: Infinite loop in RecursionLimiter.infiniteLoop()
-* 10114: ArrayIndexOutOfBoundsException in SecretNotesController.setup()
-*  2623: FreeRotator does not update masked image if sides change
+[size=16][b]Changes since 3.5.6[/b][/size]
 
-Other improvements
+Bug fixes
 
-* 14477: MouseoverStackViewer: Show a single card when used in a PlayerHand window
-* 14453: Improved error message on failure to load a deck
-* 14408: Lock logs and saves during writes to preempt locking by programs like Dropbox
+* 14540: PgDn stopped scrolling maps downward
+* 14527: NoSuchMethodError when calling ArchiveWriter.save()
+* 14526: IllegalArgumentException when rendering empty labels
+* 14521: NPE in CounterDetailViewer when Stack shapes array is longer than the piece count
 
 See the [url=http://www.vassalengine.org/wiki/VASSAL_{{version_feature}}_Release_Notes]Release Notes[/url] for descriptions of the changes in {{version_feature}}.
 

diff --git a/dist/notes/NOTES-csw.jinja b/dist/notes/NOTES-csw.jinja
@@ -12,57 +12,29 @@ The VASSAL Team is happy to announce VASSAL {{version}}.
 * <a href='https://github.com/vassalengine/vassal/releases/download/{{version}}/VASSAL-{{version}}-windows-32.exe' target='_new'>Windows (32-bit)</a>
 * <a href='https://github.com/vassalengine/vassal/releases/download/{{version}}/VASSAL-{{version}}-other.zip'  target='_new'>Other</a>
 
-<h3>Changes since 3.5.6</h3>
+<h3>Changes since 3.5.7</h3>
 
 Bug fixes
 
-* 14540: PgDn stopped scrolling maps downward
-* 14527: NoSuchMethodError when calling ArchiveWriter.save()
-* 14526: IllegalArgumentException when rendering empty labels
-* 14521: NPE in CounterDetailViewer when Stack shapes array is longer than the piece count
+* 14599: Error logs should be read from disk as UTF-8
+* 14596: Removed initial heap setting for Importer, unused since 3.5.4
+* 14579: Mass Piece Loader cannot add 'standard' layer traits
+* 14570: Longer cancel wizard text shifts wizard divider position
+* 14568: Counter Global Key Command expression does not see properties in lower traits
+* 14479: GamePieceImages recognized by unused image removal tool
 
-<h3>Changes since 3.5.5</h3>
+Other improvements
 
-Bug fixes
+* 14600: Switch bug tracker to GitHub
 
-* 14518: Zoomer hotkeys should take effect only if their map is focused
-* 14506: NPE in PieceWindow.launchButtonPressed()
-* 14505: Edit Extension menu item should be disabled when the extension is already being edited
-* 14504: Improved results for users who started with no password and then set one later
-* 14503: Set errorLog encoding explicitly to UTF-8
-* 14502: Tailer misdecodes errorLog
-* 14484: Module editing permanently disabled after editing associated Extension
-* 14469: Java's ProcessBuilder misencodes Unicode outside Latin1 on Windows
-* 14468: MouseoverStackViewer: corrected text centering problem with "extra space between" setting
-* 14461: NPE in TableInfo.getExpressionList()
-* 14460: StackOverflowError when referencing _Level property in layer-following expression
-* 14456: ConcurrentModificationException in GameState.setup() when component setup() adds components
-* 14452: Catch PatternSyntaxException on user-provided regexes
-* 14440: Counter refresh function sometimes changes stacking order of pieces
-* 14422: ArrayIndexOutOfBoundsException in Embellishment.getProperty()
-* 14418: MassPieceLoader: Copy/Paste of Modified Layer trait generates Standard Layer on Paste
-* 14401: Cancelling a predefined-setup load during setup wizard shouldn't show "Loaded..." message
-* 14393: Don't show that sending bug reports failed when they've succeeded
-* 14386: Editor was reporting module saved when the "confirm overwrite" dialog cancelled
-* 14370: NPE in BasicLogger.write() when there is no game state to write
-* 14368: Using String functions on property names containing double quotes in value causes Bad Module Data errors
-* 14351: NPE when Player Roster deleted from module
-* 14337: Show/Hide Palette Hotkey shows but does not hide
-* 14325: TileNotFoundException after second copy of a module in use is removed
-* 14311: Cancelling edit where a Hotkey name was changed does not cancel changes
-* 14308: Bad encoding in errorLog, bug reports
-* 14286: Prevent bad expressions from returning null
-* 14271: Chat & Notes input panel(s) treat Hotkeys differently
-* 14261: StackOverflowError: Infinite loop caused by Text Label wasn't being caught properly
-* 10755: Infinite loop in RecursionLimiter.infiniteLoop()
-* 10114: ArrayIndexOutOfBoundsException in SecretNotesController.setup()
-*  2623: FreeRotator does not update masked image if sides change
+<h3>Changes since 3.5.6</h3>
 
-Other improvements
+Bug fixes
 
-* 14477: MouseoverStackViewer: Show a single card when used in a PlayerHand window
-* 14453: Improved error message on failure to load a deck
-* 14408: Lock logs and saves during writes to preempt locking by programs like Dropbox
+* 14540: PgDn stopped scrolling maps downward
+* 14527: NoSuchMethodError when calling ArchiveWriter.save()
+* 14526: IllegalArgumentException when rendering empty labels
+* 14521: NPE in CounterDetailViewer when Stack shapes array is longer than the piece count
 
 See the <a href="http://www.vassalengine.org/wiki/VASSAL_{{version_feature}}_Release_Notes">Release Notes</a> for descriptions of the changes in {{version_feature}}.
 

diff --git a/dist/notes/NOTES-fb.jinja b/dist/notes/NOTES-fb.jinja
@@ -5,11 +5,17 @@ Download: https://github.com/vassalengine/vassal/releases/tag/{{version}}
 
 Release notes: http://www.vassalengine.org/wiki/VASSAL_{{version_feature}}_Release_Notes
 
-Changes since 3.5.6:
+Changes since 3.5.7:
 
 Bug fixes
 
-* 14540: PgDn stopped scrolling maps downward
-* 14527: NoSuchMethodError when calling ArchiveWriter.save()
-* 14526: IllegalArgumentException when rendering empty labels
-* 14521: NPE in CounterDetailViewer when Stack shapes array is longer than the piece count
+* 14599: Error logs should be read from disk as UTF-8
+* 14596: Removed initial heap setting for Importer, unused since 3.5.4
+* 14579: Mass Piece Loader cannot add 'standard' layer traits
+* 14570: Longer cancel wizard text shifts wizard divider position
+* 14568: Counter Global Key Command expression does not see properties in lower traits
+* 14479: GamePieceImages recognized by unused image removal tool
+
+Other improvements
+
+* 14600: Switch bug tracker to GitHub
diff --git a/dist/notes/NOTES-news.jinja b/dist/notes/NOTES-news.jinja
@@ -18,59 +18,31 @@ The VASSAL Team is happy to announce VASSAL {{version}}.
   <li><a href='https://github.com/vassalengine/vassal/releases/download/{{version}}/VASSAL-{{version}}-other.zip'  target='_new'>Other</a></li>
 </ul>
 
-<h2>Changes since 3.5.6</h2>
+<h2>Changes since 3.5.7</h2>
 
 <h3>Bug fixes</h3>
 <ul>
-<li>14540: PgDn stopped scrolling maps downward</li>
-<li>14527: NoSuchMethodError when calling ArchiveWriter.save()</li>
-<li>14526: IllegalArgumentException when rendering empty labels</li>
-<li>14521: NPE in CounterDetailViewer when Stack shapes array is longer than the piece count</li>
+<li>14599: Error logs should be read from disk as UTF-8</li>
+<li>14596: Removed initial heap setting for Importer, unused since 3.5.4</li>
+<li>14579: Mass Piece Loader cannot add 'standard' layer traits</li>
+<li>14570: Longer cancel wizard text shifts wizard divider position</li>
+<li>14568: Counter Global Key Command expression does not see properties in lower traits</li>
+<li>14479: GamePieceImages recognized by unused image removal tool
 </ul>
 
-<h2>Changes since 3.5.5</h2>
-
-<h3>Bug fixes</h3>
+<h3>Other improvements</h3>
 <ul>
-<li>14518: Zoomer hotkeys should take effect only if their map is focused</li>
-<li>14506: NPE in PieceWindow.launchButtonPressed()</li>
-<li>14505: Edit Extension menu item should be disabled when the extension is already being edited</li>
-<li>14504: Improved results for users who started with no password and then set one later</li>
-<li>14503: Set errorLog encoding explicitly to UTF-8</li>
-<li>14502: Tailer misdecodes errorLog</li>
-<li>14484: Module editing permanently disabled after editing associated Extension</li>
-<li>14469: Java's ProcessBuilder misencodes Unicode outside Latin1 on Windows</li>
-<li>14468: MouseoverStackViewer: corrected text centering problem with "extra space between" setting</li>
-<li>14461: NPE in TableInfo.getExpressionList()</li>
-<li>14460: StackOverflowError when referencing _Level property in layer-following expression</li>
-<li>14456: ConcurrentModificationException in GameState.setup() when component setup() adds components</li>
-<li>14452: Catch PatternSyntaxException on user-provided regexes</li>
-<li>14440: Counter refresh function sometimes changes stacking order of pieces</li>
-<li>14422: ArrayIndexOutOfBoundsException in Embellishment.getProperty()</li>
-<li>14418: MassPieceLoader: Copy/Paste of Modified Layer trait generates Standard Layer on Paste</li>
-<li>14401: Cancelling a predefined-setup load during setup wizard shouldn't show "Loaded..." message</li>
-<li>14393: Don't show that sending bug reports failed when they've succeeded</li>
-<li>14386: Editor was reporting module saved when the "confirm overwrite" dialog cancelled</li>
-<li>14370: NPE in BasicLogger.write() when there is no game state to write</li>
-<li>14368: Using String functions on property names containing double quotes in value causes Bad Module Data errors</li>
-<li>14351: NPE when Player Roster deleted from module</li>
-<li>14337: Show/Hide Palette Hotkey shows but does not hide</li>
-<li>14325: TileNotFoundException after second copy of a module in use is removed</li>
-<li>14311: Cancelling edit where a Hotkey name was changed does not cancel changes</li>
-<li>14308: Bad encoding in errorLog, bug reports</li>
-<li>14286: Prevent bad expressions from returning null</li>
-<li>14271: Chat & Notes input panel(s) treat Hotkeys differently</li>
-<li>14261: StackOverflowError: Infinite loop caused by Text Label wasn't being caught properly</li>
-<li>10755: Infinite loop in RecursionLimiter.infiniteLoop()</li>
-<li>10114: ArrayIndexOutOfBoundsException in SecretNotesController.setup()</li>
-<li>2623: FreeRotator does not update masked image if sides change</li>
+<li>14600: Switch bug tracker to GitHub</li>
 </ul>
 
-<h3>Other improvements</h3>
+<h2>Changes since 3.5.6</h2>
+
+<h3>Bug fixes</h3>
 <ul>
-<li>14477: MouseoverStackViewer: Show a single card when used in a PlayerHand window</li>
-<li>14453: Improved error message on failure to load a deck</li>
-<li>14408: Lock logs and saves during writes to preempt locking by programs like Dropbox</li>
+<li>14540: PgDn stopped scrolling maps downward</li>
+<li>14527: NoSuchMethodError when calling ArchiveWriter.save()</li>
+<li>14526: IllegalArgumentException when rendering empty labels</li>
+<li>14521: NPE in CounterDetailViewer when Stack shapes array is longer than the piece count</li>
 </ul>
 
 <p>

diff --git a/dist/notes/NOTES-vassalforum.jinja b/dist/notes/NOTES-vassalforum.jinja
@@ -17,57 +17,29 @@ The VASSAL Team is happy to announce VASSAL {{version}}.
 [url=https://github.com/vassalengine/vassal/releases/download/{{version}}/VASSAL-{{version}}-windows-32.exe]Windows (32-bit)[/url]
 [url=https://github.com/vassalengine/vassal/releases/download/{{version}}/VASSAL-{{version}}-other.zip]Other[/url]
 
-[size=150][b]Changes since 3.5.6[/b][/size]
+[size=150][b]Changes since 3.5.7[/b][/size]
 
 Bug fixes
 
-* 14540: PgDn stopped scrolling maps downward
-* 14527: NoSuchMethodError when calling ArchiveWriter.save()
-* 14526: IllegalArgumentException when rendering empty labels
-* 14521: NPE in CounterDetailViewer when Stack shapes array is longer than the piece count
+* 14599: Error logs should be read from disk as UTF-8
+* 14596: Removed initial heap setting for Importer, unused since 3.5.4
+* 14579: Mass Piece Loader cannot add 'standard' layer traits
+* 14570: Longer cancel wizard text shifts wizard divider position
+* 14568: Counter Global Key Command expression does not see properties in lower traits
+* 14479: GamePieceImages recognized by unused image removal tool
 
-[size=150][b]Changes since 3.5.5[/b][/size]
+Other improvements
 
-Bug fixes
+* 14600: Switch bug tracker to GitHub
 
-* 14518: Zoomer hotkeys should take effect only if their map is focused
-* 14506: NPE in PieceWindow.launchButtonPressed()
-* 14505: Edit Extension menu item should be disabled when the extension is already being edited
-* 14504: Improved results for users who started with no password and then set one later
-* 14503: Set errorLog encoding explicitly to UTF-8
-* 14502: Tailer misdecodes errorLog
-* 14484: Module editing permanently disabled after editing associated Extension
-* 14469: Java's ProcessBuilder misencodes Unicode outside Latin1 on Windows
-* 14468: MouseoverStackViewer: corrected text centering problem with "extra space between" setting
-* 14461: NPE in TableInfo.getExpressionList()
-* 14460: StackOverflowError when referencing _Level property in layer-following expression
-* 14456: ConcurrentModificationException in GameState.setup() when component setup() adds components
-* 14452: Catch PatternSyntaxException on user-provided regexes
-* 14440: Counter refresh function sometimes changes stacking order of pieces
-* 14422: ArrayIndexOutOfBoundsException in Embellishment.getProperty()
-* 14418: MassPieceLoader: Copy/Paste of Modified Layer trait generates Standard Layer on Paste
-* 14401: Cancelling a predefined-setup load during setup wizard shouldn't show "Loaded..." message
-* 14393: Don't show that sending bug reports failed when they've succeeded
-* 14386: Editor was reporting module saved when the "confirm overwrite" dialog cancelled
-* 14370: NPE in BasicLogger.write() when there is no game state to write
-* 14368: Using String functions on property names containing double quotes in value causes Bad Module Data errors
-* 14351: NPE when Player Roster deleted from module
-* 14337: Show/Hide Palette Hotkey shows but does not hide
-* 14325: TileNotFoundException after second copy of a module in use is removed
-* 14311: Cancelling edit where a Hotkey name was changed does not cancel changes
-* 14308: Bad encoding in errorLog, bug reports
-* 14286: Prevent bad expressions from returning null
-* 14271: Chat & Notes input panel(s) treat Hotkeys differently
-* 14261: StackOverflowError: Infinite loop caused by Text Label wasn't being caught properly
-* 10755: Infinite loop in RecursionLimiter.infiniteLoop()
-* 10114: ArrayIndexOutOfBoundsException in SecretNotesController.setup()
-*  2623: FreeRotator does not update masked image if sides change
+[size=150][b]Changes since 3.5.6[/b][/size]
 
-Other improvements
+Bug fixes
 
-* 14477: MouseoverStackViewer: Show a single card when used in a PlayerHand window
-* 14453: Improved error message on failure to load a deck
-* 14408: Lock logs and saves during writes to preempt locking by programs like Dropbox
+* 14540: PgDn stopped scrolling maps downward
+* 14527: NoSuchMethodError when calling ArchiveWriter.save()
+* 14526: IllegalArgumentException when rendering empty labels
+* 14521: NPE in CounterDetailViewer when Stack shapes array is longer than the piece count
 
 See the [url=http://www.vassalengine.org/wiki/VASSAL_{{version_feature}}_Release_Notes]Release Notes[/url] for descriptions of the changes in {{version_feature}}.
 

diff --git a/pom.xml b/pom.xml
@@ -4,7 +4,7 @@
 
     <groupId>org.vassalengine</groupId>
     <artifactId>vassal-parent</artifactId>
-    <version>3.5.8-SNAPSHOT</version>
+    <version>3.5.8</version>
     <packaging>pom</packaging>
 
     <name>Vassal Engine</name>

diff --git a/release-prepare/pom.xml b/release-prepare/pom.xml
@@ -5,11 +5,11 @@
     <parent>
         <groupId>org.vassalengine</groupId>
         <artifactId>vassal-parent</artifactId>
-        <version>3.5.8-SNAPSHOT</version>
+        <version>3.5.8</version>
     </parent>
 
     <artifactId>release-prepare</artifactId>
-    <version>3.5.8-SNAPSHOT</version>
+    <version>3.5.8</version>
     <packaging>pom</packaging>
 
     <properties>

diff --git a/vassal-app/pom.xml b/vassal-app/pom.xml
@@ -5,11 +5,11 @@
     <parent>
         <groupId>org.vassalengine</groupId>
         <artifactId>vassal-parent</artifactId>
-        <version>3.5.8-SNAPSHOT</version>
+        <version>3.5.8</version>
     </parent>
 
     <artifactId>vassal-app</artifactId>
-    <version>3.5.8-SNAPSHOT</version>
+    <version>3.5.8</version>
     <packaging>jar</packaging>
 
     <name>${project.artifactId}</name>

diff --git a/vassal-deprecation/pom.xml b/vassal-deprecation/pom.xml
@@ -5,11 +5,11 @@
     <parent>
         <groupId>org.vassalengine</groupId>
         <artifactId>vassal-parent</artifactId>
-        <version>3.5.8-SNAPSHOT</version>
+        <version>3.5.8</version>
     </parent>
 
     <artifactId>vassal-deprecation</artifactId>
-    <version>3.5.8-SNAPSHOT</version>
+    <version>3.5.8</version>
     <packaging>jar</packaging>
 
     <properties>