Skip to content

Commit

Permalink
Remove ninja from docker image build (huggingface#31080)
Browse files Browse the repository at this point in the history
fix

Co-authored-by: ydshieh <[email protected]>
  • Loading branch information
2 people authored and vasqu committed Jun 1, 2024
1 parent 8b91c20 commit 5e211d5
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 12 deletions.
4 changes: 4 additions & 0 deletions docker/transformers-all-latest-gpu/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ RUN python3 -m pip install --no-cache-dir bitsandbytes
# Some tests require quanto
RUN python3 -m pip install --no-cache-dir quanto

# `quanto` will install `ninja` which leads to many `CUDA error: an illegal memory access ...` in some model tests
# (`deformable_detr`, `rwkv`, `mra`)
RUN python3 -m pip uninstall -y ninja

# For `dinat` model
# The `XXX` part in `torchXXX` needs to match `PYTORCH` (to some extent)
RUN python3 -m pip install --no-cache-dir natten==0.15.1+torch220$CUDA -f https://shi-labs.com/natten/wheels
Expand Down
6 changes: 0 additions & 6 deletions tests/models/deformable_detr/test_modeling_deformable_detr.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,12 +232,6 @@ def setUp(self):
self.model_tester = DeformableDetrModelTester(self)
self.config_tester = ConfigTester(self, config_class=DeformableDetrConfig, has_text_modality=False)

@unittest.skip(
"This starts to fail since 2024/05/24, but earlier commits also fail now and affect many other tests. The error is `an illegal memory access was encountered`."
)
def test_model_parallelism(self):
super().test_model_parallelism()

def test_config(self):
# we don't test common_properties and arguments_init as these don't apply for Deformable DETR
self.config_tester.create_and_test_config_to_json_string()
Expand Down
6 changes: 0 additions & 6 deletions tests/models/rwkv/test_modeling_rwkv.py
Original file line number Diff line number Diff line change
Expand Up @@ -304,12 +304,6 @@ def assertInterval(self, member, container, msg=None):
standardMsg = "%s not found in %s" % (safe_repr(member), safe_repr(container))
self.fail(self._formatMessage(msg, standardMsg))

@unittest.skip(
"This starts to fail since 2024/05/24, but earlier commits also fail now and affect many other tests. The error is `an illegal memory access was encountered`."
)
def test_model_parallelism(self):
super().test_model_parallelism()

def test_config(self):
self.config_tester.run_common_tests()

Expand Down

0 comments on commit 5e211d5

Please sign in to comment.