Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README, because nothing is ever simple #769

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

Burgestrand
Copy link
Member

This is an irk of mine. No ill was meant when these words were written, but I feel using the word "simply" is a bit crass.

To do

  • I have read the contributing guidelines.
  • I have added relevant tests.
  • I have adjusted relevant documentation.
  • I have made sure the individual commits are meaningful.
  • I have added relevant lines to the CHANGELOG.

PS: Thank you for contributing to Pundit ❤️

In writing, assuming something is "simple", "obvious", "just do it", and similar is an irk of mine. No ill was meant when these words were originally written.
@Burgestrand Burgestrand force-pushed the kbs/adjust-readme-wording branch from d3eeb84 to 64228ce Compare May 10, 2023 12:51
@Burgestrand Burgestrand requested a review from dgmstuart May 10, 2023 14:36
@Burgestrand
Copy link
Member Author

@dgmstuart I'm not sure if this is the improvement I intend it to be. wdyt, is it better or worse?

dgmstuart
dgmstuart previously approved these changes May 17, 2023
Copy link
Collaborator

@dgmstuart dgmstuart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some comments but mostly this feels like an improvement.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@Burgestrand Burgestrand merged commit a9e02df into main Jul 17, 2023
@Burgestrand Burgestrand deleted the kbs/adjust-readme-wording branch July 17, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants