Update OpenTelemetryMetrics.scala

varshith257 · Dec 11, 2024 · eec5498 · eec5498
1 parent a3ebd6c
commit eec5498
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/...metrics/src/main/scala/sttp/tapir/server/metrics/opentelemetry/OpenTelemetryMetrics.scala b/...metrics/src/main/scala/sttp/tapir/server/metrics/opentelemetry/OpenTelemetryMetrics.scala
@@ -51,13 +51,13 @@ object OpenTelemetryMetrics {
     ),
     forResponse = List(
       "http.response.status_code" -> {
-        case Right(r) => r.code.code.toString
+        case Right(r) => Some(r.code.code.toString)
         // Default to 500 for exceptions
-        case Left(_) => "500"
+        case Left(_) => Some("500")
       },
       "error.type" -> {
-        case Left(ex) => ex.getClass.getName // Exception class name for errors
-        case Right(_) => ""
+        case Left(ex) => Some(ex.getClass.getName) // Exception class name for errors
+        case Right(_) => None
       }
     )
   )
@@ -199,8 +199,7 @@ object OpenTelemetryMetrics {
   private def asOpenTelemetryAttributes(l: MetricLabels, res: Either[Throwable, ServerResponse[_]], phase: Option[String]): Attributes = {
     val builder = Attributes.builder()
     l.forResponse.foreach { case (key, valueFn) =>
-      val value = valueFn(res)
-      if (value.nonEmpty) builder.put(key, value)
+      valueFn(res).foreach(value => builder.put(key, value))
     }
     phase.foreach(v => builder.put(l.forResponsePhase.name, v))
     builder.build()