Skip to content

Commit

Permalink
Issue argoproj#283 - API server incorrectly compose application fully…
Browse files Browse the repository at this point in the history
… qualified name for RBAC check (argoproj#284)
  • Loading branch information
alexmt authored Jun 13, 2018
1 parent 271b57e commit 3fbbe94
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion server/application/application.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package application
import (
"bufio"
"encoding/json"
"fmt"
"path"
"reflect"
"strings"
Expand Down Expand Up @@ -69,7 +70,7 @@ func NewServer(

// appRBACName formats fully qualified application name for RBAC check
func appRBACName(app appv1.Application) string {
return path.Join(git.NormalizeGitURL(app.Spec.Source.RepoURL), app.Name)
return fmt.Sprintf("%s/%s", git.NormalizeGitURL(app.Spec.Source.RepoURL), app.Name)
}

// List returns list of applications
Expand Down

0 comments on commit 3fbbe94

Please sign in to comment.