backend.list -j now outputs IPs/port information #4197
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since DNS resolution happens only once for static backends and can be a bit obscure for dynamic backend, it's valuable to be able to dump the IPs that are used.
In order to not break existing scripts which may
varnishadm backend.list
, only update the JSON ouputside note: it's a bit confusing that
vbe_list
needs to produce a JSON value ending with a coma ifpflag
is true, but not if it's false. Do we want to change that? And also maybe make printing theprobe_details
andprobe_message
a responsibilty of the backend implementation, rather than splitting the key-value pair across two functions?