Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend.list -j now outputs IPs/port information #4197

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

gquintard
Copy link
Member

since DNS resolution happens only once for static backends and can be a bit obscure for dynamic backend, it's valuable to be able to dump the IPs that are used.

In order to not break existing scripts which may varnishadm backend.list, only update the JSON ouput

side note: it's a bit confusing that vbe_list needs to produce a JSON value ending with a coma if pflag is true, but not if it's false. Do we want to change that? And also maybe make printing the probe_details and probe_message a responsibilty of the backend implementation, rather than splitting the key-value pair across two functions?

bin/varnishtest/tests/b00091.vtc Show resolved Hide resolved
@nigoroll nigoroll merged commit dbd1cdf into varnishcache:master Sep 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants