Chore: reduce attack surface and size for Docker image #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, thanks for opening this. What's the size gain with this? |
|
Hi @gquintard, I updated the differences between the builds before and after the improvement as below:
Without
I hope you find this additional information helpful. |
|
after looking at the output of All in all the size gain is negligible, the security benefit is about zero, but on my laptop, the image build a lot faster (3:15 down from 5:45), I'll take that win. Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This pull request includes a small improvement for the Dockerfile, which should help improve the security of container and reduce the risk of potential attacks.
In detail:
--no-install-recommendsto remove unnecessaryaptpackages, that were not needed for the container's functionality. Not only can this change trim your image size but it also can also reduce the attack surface.I hope that you find them useful. Please let me know if you have any concerns.
Thank you.